Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: appengine/swarming/ui/res/imp/botlist/bot-filters.html

Issue 2858953002: Fix accidental alias deapplication (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | appengine/swarming/ui/res/imp/tasklist/task-filters.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/ui/res/imp/botlist/bot-filters.html
diff --git a/appengine/swarming/ui/res/imp/botlist/bot-filters.html b/appengine/swarming/ui/res/imp/botlist/bot-filters.html
index 93ee6b58cedf5bdf0233629491847041a8e625ee..3bdc6b009b231a4418b74741028375f09dc574bc 100644
--- a/appengine/swarming/ui/res/imp/botlist/bot-filters.html
+++ b/appengine/swarming/ui/res/imp/botlist/bot-filters.html
@@ -276,7 +276,10 @@ the fleet.">
var col = split[0];
if (this.dimensions.indexOf(col) !== -1) {
var rest = f.substring(col.length + this.FILTER_SEP.length);
- dims.push(col + this.FILTER_SEP + swarming.alias.unapply(rest))
+ if (swarming.alias.DIMENSIONS_WITH_ALIASES.indexOf(col) !== -1) {
+ rest = swarming.alias.unapply(rest);
+ }
+ dims.push(col + this.FILTER_SEP + rest)
} else if (col === "status") {
var rest = f.substring(col.length + this.FILTER_SEP.length);
if (rest === "alive") {
« no previous file with comments | « appengine/swarming/ui/build/elements.html ('k') | appengine/swarming/ui/res/imp/tasklist/task-filters.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698