Add flag for disabling minimum of ntp tile suggestions

components/suggestions/features.cc

Index: components/suggestions/features.cc
diff --git a/components/suggestions/features.cc b/components/suggestions/features.cc
new file mode 100644
index 0000000000000000000000000000000000000000..610e1f7e6a60af3b8af697d73e637866eaa8107c
--- /dev/null
+++ b/components/suggestions/features.cc
@@ -0,0 +1,14 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/suggestions/features.h"
+
+namespace suggestions {
+
+// If this feature is enabled, we request and use suggestions even if there are
+// only very few of them.

[Marc Treib, 2017/05/03 11:43:56]

s/only very few/less than 8/ ? (That's really what it means, right?)

Also, should this comment be in the header?

[fhorschig, 2017/05/03 14:19:42]

Hmm, actually the server-side config differentiates between mobile 
with 8 suggestions and desktop with 4. 
Currently, we would only see the effect for mobile but technically
there is a difference.
Moved. Although I am not sure. 

(We do this for ntp_{tiles,snippets} but large lists don't:
content/public/common/content_features.cc
https://cs.chromium.org/search/?q=f:%5C.cc+%5Cs*const%5Cs*base::Feature
Is there a standard? Is it important enough to think about deeply?)

[Marc Treib, 2017/05/03 14:28:41]

...wait, really? If anything, shouldn't it be the other way around?
Personally, I'm more likely to look in the header for a description, but I don't
know if there's a standard. Nope, not important enough to worry over :)

[fhorschig, 2017/05/04 07:39:58]

As discussed, this is the default config that might be overridden.
Thanks!

+const base::Feature kDisableSuggestionsMinimumFeature{
+    "DisableSuggestionsMinimum", base::FEATURE_DISABLED_BY_DEFAULT};

[Marc Treib, 2017/05/03 11:43:56]

Hm, not a fan of a feature that starts with "Disable". I find it confusing to
figure out what the actual state is when the feature is disabled...

How about something like "SuggestionsNoMinimum"?

[fhorschig, 2017/05/03 14:19:42]

Renamed.

+
+}  // namespace suggestions