Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: components/suggestions/features.cc

Issue 2858883002: Add flag for disabling minimum of ntp tile suggestions (Closed)
Patch Set: Replace switch with feature Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/suggestions/features.h"
6
7 namespace suggestions {
8
9 // If this feature is enabled, we request and use suggestions even if there are
10 // only very few of them.
Marc Treib 2017/05/03 11:43:56 s/only very few/less than 8/ ? (That's really what
fhorschig 2017/05/03 14:19:42 Hmm, actually the server-side config differentiate
Marc Treib 2017/05/03 14:28:41 ...wait, really? If anything, shouldn't it be the
fhorschig 2017/05/04 07:39:58 As discussed, this is the default config that migh
11 const base::Feature kDisableSuggestionsMinimumFeature{
12 "DisableSuggestionsMinimum", base::FEATURE_DISABLED_BY_DEFAULT};
Marc Treib 2017/05/03 11:43:56 Hm, not a fan of a feature that starts with "Disab
fhorschig 2017/05/03 14:19:42 Renamed.
13
14 } // namespace suggestions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698