Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2858883002: Add flag for disabling minimum of ntp tile suggestions (Closed)
Patch Set: Replace switch with feature Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 #include "components/password_manager/core/common/password_manager_features.h" 59 #include "components/password_manager/core/common/password_manager_features.h"
60 #include "components/proximity_auth/switches.h" 60 #include "components/proximity_auth/switches.h"
61 #include "components/security_state/core/security_state.h" 61 #include "components/security_state/core/security_state.h"
62 #include "components/security_state/core/switches.h" 62 #include "components/security_state/core/switches.h"
63 #include "components/signin/core/common/signin_switches.h" 63 #include "components/signin/core/common/signin_switches.h"
64 #include "components/spellcheck/common/spellcheck_features.h" 64 #include "components/spellcheck/common/spellcheck_features.h"
65 #include "components/spellcheck/common/spellcheck_switches.h" 65 #include "components/spellcheck/common/spellcheck_switches.h"
66 #include "components/spellcheck/spellcheck_build_features.h" 66 #include "components/spellcheck/spellcheck_build_features.h"
67 #include "components/ssl_config/ssl_config_switches.h" 67 #include "components/ssl_config/ssl_config_switches.h"
68 #include "components/strings/grit/components_strings.h" 68 #include "components/strings/grit/components_strings.h"
69 #include "components/suggestions/features.h"
69 #include "components/sync/driver/sync_driver_switches.h" 70 #include "components/sync/driver/sync_driver_switches.h"
70 #include "components/tracing/common/tracing_switches.h" 71 #include "components/tracing/common/tracing_switches.h"
71 #include "components/translate/core/browser/translate_manager.h" 72 #include "components/translate/core/browser/translate_manager.h"
72 #include "components/translate/core/browser/translate_prefs.h" 73 #include "components/translate/core/browser/translate_prefs.h"
73 #include "components/version_info/version_info.h" 74 #include "components/version_info/version_info.h"
74 #include "content/public/common/content_features.h" 75 #include "content/public/common/content_features.h"
75 #include "content/public/common/content_switches.h" 76 #include "content/public/common/content_switches.h"
76 #include "content/public/common/feature_h264_with_openh264_ffmpeg.h" 77 #include "content/public/common/feature_h264_with_openh264_ffmpeg.h"
77 #include "content/public/common/features.h" 78 #include "content/public/common/features.h"
78 #include "device/base/features.h" 79 #include "device/base/features.h"
(...skipping 2703 matching lines...) Expand 10 before | Expand all | Expand 10 after
2782 {"enable-heap-profiling", flag_descriptions::kEnableHeapProfilingName, 2783 {"enable-heap-profiling", flag_descriptions::kEnableHeapProfilingName,
2783 flag_descriptions::kEnableHeapProfilingDescription, kOsAll, 2784 flag_descriptions::kEnableHeapProfilingDescription, kOsAll,
2784 MULTI_VALUE_TYPE(kEnableHeapProfilingChoices)}, 2785 MULTI_VALUE_TYPE(kEnableHeapProfilingChoices)},
2785 2786
2786 #if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS)) 2787 #if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS))
2787 {"show-cert-link", flag_descriptions::kShowCertLinkOnPageInfoName, 2788 {"show-cert-link", flag_descriptions::kShowCertLinkOnPageInfoName,
2788 flag_descriptions::kShowCertLinkOnPageInfoDescription, kOsDesktop, 2789 flag_descriptions::kShowCertLinkOnPageInfoDescription, kOsDesktop,
2789 SINGLE_VALUE_TYPE(switches::kShowCertLink)}, 2790 SINGLE_VALUE_TYPE(switches::kShowCertLink)},
2790 #endif 2791 #endif
2791 2792
2793 {"disable-suggestions-minimum",
2794 flag_descriptions::kDisableSuggestionsMinimumName,
2795 flag_descriptions::kDisableSuggestionsMinimumDescription, kOsAll,
2796 FEATURE_VALUE_TYPE(suggestions::kDisableSuggestionsMinimumFeature)},
2797
2792 // NOTE: Adding new command-line switches requires adding corresponding 2798 // NOTE: Adding new command-line switches requires adding corresponding
2793 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2799 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2794 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2800 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2795 }; 2801 };
2796 2802
2797 class FlagsStateSingleton { 2803 class FlagsStateSingleton {
2798 public: 2804 public:
2799 FlagsStateSingleton() 2805 FlagsStateSingleton()
2800 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2806 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2801 ~FlagsStateSingleton() {} 2807 ~FlagsStateSingleton() {}
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
3007 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3013 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3008 3014
3009 const FeatureEntry* GetFeatureEntries(size_t* count) { 3015 const FeatureEntry* GetFeatureEntries(size_t* count) {
3010 *count = arraysize(kFeatureEntries); 3016 *count = arraysize(kFeatureEntries);
3011 return kFeatureEntries; 3017 return kFeatureEntries;
3012 } 3018 }
3013 3019
3014 } // namespace testing 3020 } // namespace testing
3015 3021
3016 } // namespace about_flags 3022 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698