Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp

Issue 2858873002: [SPv2] Refactor PaintInvalidator to be multicol-ready. (Closed)
Patch Set: none Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
diff --git a/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp b/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
index 126c4eb81d8c5f83cfde9a2dba216fe31051feae..895e276a88c25a40783df3df6ab68a613488931c 100644
--- a/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
+++ b/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
@@ -19,7 +19,7 @@ struct PrePaintTreeWalkContext {
PrePaintTreeWalkContext()
: tree_builder_context(
WTF::WrapUnique(new PaintPropertyTreeBuilderContext)),
- paint_invalidator_context(tree_builder_context.get()),
+ paint_invalidator_context(),
Xianzhu 2017/05/03 17:29:44 Nit: Remove the above line?
chrishtr 2017/05/03 18:04:35 Done.
ancestor_overflow_paint_layer(nullptr),
ancestor_transformed_or_root_paint_layer(nullptr) {}
@@ -30,8 +30,7 @@ struct PrePaintTreeWalkContext {
? new PaintPropertyTreeBuilderContext(
*parent_context.tree_builder_context)
: nullptr)),
- paint_invalidator_context(tree_builder_context.get(),
- parent_context.paint_invalidator_context),
+ paint_invalidator_context(parent_context.paint_invalidator_context),
ancestor_overflow_paint_layer(
parent_context.ancestor_overflow_paint_layer),
ancestor_transformed_or_root_paint_layer(
@@ -94,6 +93,7 @@ void PrePaintTreeWalk::Walk(FrameView& frame_view,
*context.tree_builder_context);
}
paint_invalidator_.InvalidatePaint(frame_view,
+ context.tree_builder_context.get(),
context.paint_invalidator_context);
if (LayoutView* view = frame_view.GetLayoutView()) {
@@ -312,7 +312,8 @@ void PrePaintTreeWalk::Walk(const LayoutObject& object,
object, *context.tree_builder_context);
}
- paint_invalidator_.InvalidatePaint(object, context.paint_invalidator_context);
+ paint_invalidator_.InvalidatePaint(object, context.tree_builder_context.get(),
+ context.paint_invalidator_context);
if (context.tree_builder_context) {
property_tree_builder_.UpdatePropertiesForChildren(

Powered by Google App Engine
This is Rietveld 408576698