Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2858863002: Add macro to diff the groups (and their members) in ComputedStyleBase (Closed)
Patch Set: use results from diff functions generated in ComputedStyleBase.cpp in ComputedStyle.cpp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 8440e967d80a6c07f217756695667f63a1db1455..169e2f80e80b1f1d02506f2bdf87d17482d5a1a6 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -579,10 +579,8 @@ bool ComputedStyle::ScrollAnchorDisablingPropertyChanged(
return true;
}
- if (surround_data_.Get() != other.surround_data_.Get()) {
- if (!MarginEqual(other) || !OffsetEqual(other) || !PaddingEqual(other))
- return true;
- }
+ if (ComputedStyleBase::ScrollAnchorDisablingPropertyChanged(other, diff))
+ return true;
if (diff.TransformChanged())
return true;
@@ -607,11 +605,11 @@ bool ComputedStyle::DiffNeedsFullLayoutAndPaintInvalidation(
BorderBottomWidth() != other.BorderBottomWidth() ||
BorderRightWidth() != other.BorderRightWidth())
return true;
-
- if (!PaddingEqual(other))
- return true;
}
+ if (ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation(other))
+ return true;
+
if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
if (rare_non_inherited_data_->appearance_ !=
other.rare_non_inherited_data_->appearance_ ||

Powered by Google App Engine
This is Rietveld 408576698