Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2858863002: Add macro to diff the groups (and their members) in ComputedStyleBase (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 8440e967d80a6c07f217756695667f63a1db1455..c1f2127c10433d20a26623b20532ae9fc92eb825 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -579,10 +579,7 @@ bool ComputedStyle::ScrollAnchorDisablingPropertyChanged(
return true;
}
- if (surround_data_.Get() != other.surround_data_.Get()) {
- if (!MarginEqual(other) || !OffsetEqual(other) || !PaddingEqual(other))
- return true;
- }
+ ComputedStyleBase::ScrollAnchorDisablingPropertyChanged(other, diff);
if (diff.TransformChanged())
return true;
@@ -607,11 +604,10 @@ bool ComputedStyle::DiffNeedsFullLayoutAndPaintInvalidation(
BorderBottomWidth() != other.BorderBottomWidth() ||
BorderRightWidth() != other.BorderRightWidth())
return true;
-
- if (!PaddingEqual(other))
- return true;
}
+ ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation(other);
shend 2017/05/03 05:18:12 Note that this generates an extra if check on the
nainar 2017/05/03 06:49:57 Yup.
+
if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
if (rare_non_inherited_data_->appearance_ !=
other.rare_non_inherited_data_->appearance_ ||

Powered by Google App Engine
This is Rietveld 408576698