Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

Issue 2858863002: Add macro to diff the groups (and their members) in ComputedStyleBase (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl
index 6f8132fe70b358ca26726b210874ee2cb79aad69..e2e0a87328a3ac2fefb905f07e9dda3de7b69d50 100644
--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl
@@ -1,5 +1,5 @@
{% from 'macros.tmpl' import license %}
-{% from 'fields/field.tmpl' import getter_expression, setter_expression, fieldwise_copy %}
+{% from 'fields/field.tmpl' import getter_expression, setter_expression, fieldwise_copy, fieldwise_diff %}
{{license()}}
#include "core/ComputedStyleBase.h"
@@ -48,4 +48,23 @@ void ComputedStyleBase::PropagateIndependentInheritedProperties(
{% endfor %}
}
+bool ComputedStyleBase::ScrollAnchorDisablingPropertyChanged(
+ const ComputedStyleBase& other,
+ const StyleDifference& diff) const {
+ {{fieldwise_diff(computed_style, computed_style.all_fields
+ |selectattr("property_name", "in", ["bottom", "left", "margin-bottom", "margin-left", "margin-right", "margin-top", "padding-bottom", "padding-left", "padding-right", "padding-top", "right", "top"])
shend 2017/05/03 05:18:12 I would order these properties in their original o
nainar 2017/05/03 06:49:57 Done.
+ |list
+ )|indent(2)}}
+ return false;
+}
+
+bool ComputedStyleBase::DiffNeedsFullLayoutAndPaintInvalidation(
+ const ComputedStyleBase& other) const {
+ {{fieldwise_diff(computed_style, computed_style.all_fields
+ |selectattr("property_name", "in", ["padding-bottom", "padding-left", "padding-right", "padding-top"])
shend 2017/05/03 05:18:12 same here.
nainar 2017/05/03 06:49:57 Done.
+ |list
+ )|indent(2)}}
+ return false;
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698