Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2858853002: cc : Don't draw animating layers which are transparent but raster them. (Closed)

Created:
3 years, 7 months ago by jaydasika
Modified:
3 years, 7 months ago
Reviewers:
weiliangc, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, vmpstr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Don't draw animating layers which are transparent but raster them. This is similar to https://codereview.chromium.org/2838033002/ where we do that same thing for animating layers with singular transform BUG=717818 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Total comments: 1

Patch Set 2 : update comment and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -38 lines) Patch
M cc/trees/layer_tree_host_common.cc View 1 1 chunk +15 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 3 chunks +15 lines, -25 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/property_tree.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
jaydasika
PTAL
3 years, 7 months ago (2017-05-03 01:46:19 UTC) #5
weiliangc
LGTM https://codereview.chromium.org/2858853002/diff/1/cc/trees/property_tree.cc File cc/trees/property_tree.cc (right): https://codereview.chromium.org/2858853002/diff/1/cc/trees/property_tree.cc#newcode800 cc/trees/property_tree.cc:800: // 3) Nodes with animating screen space opacity ...
3 years, 7 months ago (2017-05-03 21:19:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858853002/20001
3 years, 7 months ago (2017-05-04 01:56:35 UTC) #11
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 7 months ago (2017-05-04 03:03:35 UTC) #14
jaydasika
3 years, 7 months ago (2017-05-19 19:27:42 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2894953003/ by jaydasika@chromium.org.

The reason for reverting is: Could be the cause of crbug.com/724591.

Powered by Google App Engine
This is Rietveld 408576698