Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: sdk/lib/async/zone.dart

Issue 2858843002: Loosen type check on runZoned errorHandler (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/zone.dart
diff --git a/sdk/lib/async/zone.dart b/sdk/lib/async/zone.dart
index 1d4e12247e1de14aad9b8b62ff0b7d89716c0f93..09cc1151b20a673d0752d8390bd66247337da3c1 100644
--- a/sdk/lib/async/zone.dart
+++ b/sdk/lib/async/zone.dart
@@ -1438,7 +1438,7 @@ R runZoned<R>(R body(),
errorHandler = (Zone self, ZoneDelegate parent, Zone zone, error,
StackTrace stackTrace) {
try {
- if (onError is ZoneBinaryCallback<R, Object, StackTrace>) {
vsm 2017/05/03 01:35:48 We're failing this is-check now when onError is a
Lasse Reichstein Nielsen 2017/05/03 05:55:26 This is another case where `void` as a type parame
floitsch 2017/05/03 09:48:11 Agreed with Lasse: There should at the very least
vsm 2017/05/03 12:29:56 Done.
+ if (onError is ZoneBinaryCallback<dynamic, Object, StackTrace>) {
return self.parent.runBinary(onError, error, stackTrace);
}
return self.parent.runUnary(onError, error);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698