third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-name.html - Issue 2858803003: bluetooth: Implement simulatePreconnectedPeripheral.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-name.html

Issue 2858803003: bluetooth: Implement simulatePreconnectedPeripheral. (Closed)

Patch Set: small cleanup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/bluetooth/test/fake_central.cc ('K') | « third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-empty-name.html ('k') | third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-device-from-name-empty-filter.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

	5 <script src="../../../resources/mojo-helpers.js"></script>

	6 <script src="../../../resources/bluetooth/web-bluetooth-test.js"></script>

5 <script>	7 <script>

6 promise_test(() => {	8 promise_test(() => {

7 // The UnicodeDevice's name is '❤❤❤❤❤❤❤❤❤'. ❤ = \u2764	9 let device_name = generate_string(9, '\u2764' /* ❤ */);
	scheib 2017/05/03 20:38:49 preexisting point, but why are we using generate_s preexisting point, but why are we using generate_string? In this location, why not just '❤❤❤❤❤❤❤❤❤' directly? In other locations, just '\ucode'.repeat(123). OK to ignore in this patch. ortuno 2017/05/04 04:16:21 Changed it to 'LE Device' since there is no need f Show quoted text On 2017/05/03 at 20:38:49, scheib wrote: > preexisting point, but why are we using generate_string? > > In this location, why not just '❤❤❤❤❤❤❤❤❤' directly? Changed it to 'LE Device' since there is no need for the unicode characters. Show quoted text > In other locations, just '\ucode'.repeat(123). > > OK to ignore in this patch. Not sure why we added that function O.o http://crrev.com/2858183002
8 let device_name = generate_string(9, '\u2764');	10 return setUpSystemConnectedDevice({name: device_name})

9 return setBluetoothFakeAdapter('UnicodeDeviceAdapter')

10 .then(() => requestDeviceWithKeyDown({acceptAllDevices: true}))	11 .then(() => requestDeviceWithKeyDown({acceptAllDevices: true}))

11 .then(device => {	12 .then(device => {

12 assert_equals(device.name, device_name);	13 assert_equals(device.name, device_name);

13 });	14 });

14 }, 'A device with name and no UUIDs nearby. Should be found if ' +	15 }, 'A device with name and no UUIDs nearby. Should be found if ' +

15 'acceptAllDevices is true.');	16 'acceptAllDevices is true.');

16 </script>	17 </script>

OLD	NEW