third_party/WebKit/PerformanceTests/Canvas/toBlob_duration_jpeg.html - Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/PerformanceTests/Canvas/toBlob_duration_jpeg.html

Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback (Closed)

Patch Set: Address Xianzhu's review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/PerformanceTests/Canvas/toBlob_duration.html ('k') | third_party/WebKit/PerformanceTests/Dromaeo/resources/dromaeorunner.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/PerformanceTests/Canvas/toBlob_duration_jpeg.html

diff --git a/third_party/WebKit/PerformanceTests/Canvas/toBlob_duration_jpeg.html b/third_party/WebKit/PerformanceTests/Canvas/toBlob_duration_jpeg.html

index 42376d40e8b7e57aa6b0a7b3ac5d2bdac384bf20..37ed35b90ef0a769568a46464301ba8759f9be4f 100644

--- a/third_party/WebKit/PerformanceTests/Canvas/toBlob_duration_jpeg.html

+++ b/third_party/WebKit/PerformanceTests/Canvas/toBlob_duration_jpeg.html

@@ -33,14 +33,16 @@ function runTest(myCanvas) {

window.onload = function () {

canvas_idle = createCanvas4k("canvas_idle");

- PerfTestRunner.prepareToMeasureValuesAsync({

+ PerfTestRunner.startMeasureValuesAsync({

unit: 'ms',

done: function () {

isDone = true;

+ run: function() {

+ runTest(canvas_idle);

+ },

description: "Measures performance of canvas."

});

- runTest(canvas_idle);

};

</script>

</body>