third_party/WebKit/PerformanceTests/Bindings/post-message.html - Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/PerformanceTests/Bindings/post-message.html

Issue 2858783003: Refactor prepareToMeasureValuesAsync to startMeasureValuesAsyn which run test through callback (Closed)

Patch Set: update Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <body>	2 <body>

3 <script src="../resources/runner.js"></script>	3 <script src="../resources/runner.js"></script>

4 <script>	4 <script>

5 var isDone = false;	5 var isDone = false;

6	6

7 function runTest() {	7 function runTest() {

8 var numRound = 1000;	8 var numRound = 1000;

9 var worker = new Worker('resources/worker.js');	9 var worker = new Worker('resources/worker.js');

10	10

(...skipping 12 matching lines...) Expand all Loading...
23 }	23 }

24	24

25 function testDone() {	25 function testDone() {

26 isDone = true;	26 isDone = true;

27 }	27 }

28	28

29 window.onload = function () {	29 window.onload = function () {

30 PerfTestRunner.prepareToMeasureValuesAsync({	30 PerfTestRunner.prepareToMeasureValuesAsync({

31 description: "Measures time to run 1000 postMessage round trips in seria l.",	31 description: "Measures time to run 1000 postMessage round trips in seria l.",

32 unit: 'ms',	32 unit: 'ms',

	33 run: function() {

	34 runTest();

	35 },
	Xianzhu 2017/05/03 22:06:25 Nit: a simpler way is run: runTest, Nit: a simpler way is run: runTest, nednguyen 2017/05/04 00:10:32 Done. Show quoted text On 2017/05/03 22:06:25, Xianzhu wrote: > Nit: a simpler way is > run: runTest, Done.
33 done: testDone,	36 done: testDone,

34 });	37 });

35 runTest();

36 };	38 };

37 </script>	39 </script>

38 <div id="log"></div>	40 <div id="log"></div>

39 </body>	41 </body>

OLD	NEW