Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2858743002: NQE: Move params from the estimator class to the params class (Closed)
Patch Set: ryansturm comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index ab5cdf8c27f773d88de6ebf1d1db2c79092821c7..02d1c2cd6d3dfcd1580cb4c2a62755345f9fb8c9 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -455,7 +455,6 @@ class NET_EXPORT NetworkQualityEstimator
DefaultObservationsOverridden);
FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest,
ObtainAlgorithmToUseFromParams);
- FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest, HalfLifeParam);
FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest, ComputedPercentiles);
FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest, TestGetMetricsSince);
FRIEND_TEST_ALL_PREFIXES(NetworkQualityEstimatorTest,
@@ -669,14 +668,6 @@ class NET_EXPORT NetworkQualityEstimator
// If true, default values provided by the platform are used for estimation.
const bool add_default_platform_observations_;
- // The factor by which the weight of an observation reduces every second.
- const double weight_multiplier_per_second_;
-
- // The factor by which the weight of an observation reduces for every dBm
- // difference between the current signal strength (in dBm), and the signal
- // strength at the time when the observation was taken.
- const double weight_multiplier_per_dbm_;
-
// Algorithm to use for computing effective connection type. The value is
// obtained from field trial parameters. If the value from field trial
// parameters is unavailable, it is set to
@@ -799,25 +790,9 @@ class NET_EXPORT NetworkQualityEstimator
int32_t min_signal_strength_since_connection_change_;
int32_t max_signal_strength_since_connection_change_;
- // It is costlier to add values to a sparse histogram. So, the correlation UMA
- // is recorded with |correlation_uma_logging_probability_| since recording it
- // in a sparse histogram for each request is unnecessary and cost-prohibitive.
- // e.g., if it is 0.0, then the UMA will never be recorded. On the other hand,
- // if it is 1.0, then it will be recorded for all valid HTTP requests.
- const double correlation_uma_logging_probability_;
-
// Stores the qualities of different networks.
std::unique_ptr<nqe::internal::NetworkQualityStore> network_quality_store_;
- // True if effective connection type value has been forced via variation
- // parameters. If set to true, GetEffectiveConnectionType() will always return
- // |forced_effective_connection_type_|.
- const bool forced_effective_connection_type_set_;
- const EffectiveConnectionType forced_effective_connection_type_;
-
- // Set to true if reading of the network quality prefs is enabled.
- const bool persistent_cache_reading_enabled_;
-
base::ThreadChecker thread_checker_;
// Manages the writing of events to the net log.
« no previous file with comments | « net/BUILD.gn ('k') | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698