allow_posix_link_time_opt and is_cfi are clang features

build/config/sanitizers/sanitizers.gni

Index: build/config/sanitizers/sanitizers.gni
diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni
index 585a0658d695fdca31f0e625fc2b9b0f69a7c188..f52a18545c8f85506f65a191eb7b5796a35a3d98 100644
--- a/build/config/sanitizers/sanitizers.gni
+++ b/build/config/sanitizers/sanitizers.gni
@@ -55,7 +55,7 @@ declare_args() {
   #
   # TODO(pcc): Remove this flag if/when CFI is enabled in all official builds.
   is_cfi = target_os == "linux" && !is_chromeos && target_cpu == "x64" &&
-           is_official_build && allow_posix_link_time_opt
+           is_official_build && allow_posix_link_time_opt && is_clang

[krasin1, 2017/05/02 19:48:23]

allow_posix_link_time is a clang feature. Can you please move is_clang into
allow_posix_link_time_opt definition?

[Mostyn Bramley-Moore, 2017/05/02 19:55:34]

Thanks- I was testing that change simultaneously in another workspace, didn't
spot that they were inter-related.

 
   # Enable checks for bad casts: derived cast and unrelated cast.
   # TODO(krasin): remove this, when we're ready to add these checks by default.