Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: ui/login/account_picker/screen_account_picker.js

Issue 2858653002: Adjust error message position (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Account picker screen implementation. 6 * @fileoverview Account picker screen implementation.
7 */ 7 */
8 8
9 login.createScreen('AccountPickerScreen', 'account-picker', function() { 9 login.createScreen('AccountPickerScreen', 'account-picker', function() {
10 /** 10 /**
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 // Update the pod row display if incorrect password. 191 // Update the pod row display if incorrect password.
192 $('pod-row').setFocusedPodErrorDisplay(true); 192 $('pod-row').setFocusedPodErrorDisplay(true);
193 193
194 /** @const */ var BUBBLE_OFFSET = 25; 194 /** @const */ var BUBBLE_OFFSET = 25;
195 // -8 = 4(BUBBLE_POD_OFFSET) - 2(bubble margin) 195 // -8 = 4(BUBBLE_POD_OFFSET) - 2(bubble margin)
196 // - 10(internal bubble adjustment) 196 // - 10(internal bubble adjustment)
197 var bubblePositioningPadding = -8; 197 var bubblePositioningPadding = -8;
198 198
199 var bubbleAnchor; 199 var bubbleAnchor;
200 var attachment; 200 var attachment;
201 if (activatedPod.pinContainer) { 201 if (activatedPod.pinContainer &&
202 activatedPod.pinContainer.style.visibility == 'visible') {
202 // Anchor the bubble to the input field. 203 // Anchor the bubble to the input field.
203 bubbleAnchor = ( 204 bubbleAnchor = (
204 activatedPod.getElementsByClassName('auth-container'))[0]; 205 activatedPod.getElementsByClassName('auth-container'))[0];
205 if (!bubbleAnchor) { 206 if (!bubbleAnchor) {
206 console.error('auth-container not found!'); 207 console.error('auth-container not found!');
207 bubbleAnchor = activatedPod.mainInput; 208 bubbleAnchor = activatedPod.mainInput;
208 } 209 }
209 attachment = cr.ui.Bubble.Attachment.RIGHT; 210 attachment = cr.ui.Bubble.Attachment.RIGHT;
210 } else { 211 } else {
211 // Anchor the bubble to the pod instead of the input. 212 // Anchor the bubble to the pod instead of the input.
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 * @param {string} userID The user ID of the public session 468 * @param {string} userID The user ID of the public session
468 * @param {string} locale The locale to which this list of keyboard layouts 469 * @param {string} locale The locale to which this list of keyboard layouts
469 * applies 470 * applies
470 * @param {!Object} list List of available keyboard layouts 471 * @param {!Object} list List of available keyboard layouts
471 */ 472 */
472 setPublicSessionKeyboardLayouts: function(userID, locale, list) { 473 setPublicSessionKeyboardLayouts: function(userID, locale, list) {
473 $('pod-row').setPublicSessionKeyboardLayouts(userID, locale, list); 474 $('pod-row').setPublicSessionKeyboardLayouts(userID, locale, list);
474 } 475 }
475 }; 476 };
476 }); 477 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698