chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc - Issue 2858643002: PS - Filtering activeTab URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc

Issue 2858643002: PS - Filtering activeTab URL (Closed)

Patch Set: ExtensionBuilder in test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.h ('k') | chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc

diff --git a/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc b/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc

index 3dc599509285136337afc6e214496b45fbe993bf..c11f02abc5161be4be5134ec2ccb319414489eb4 100644

--- a/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc

+++ b/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc

@@ -7,6 +7,7 @@

#include <string>

#include "base/memory/ptr_util.h"

+#include "chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.h"

#include "chrome/browser/profiles/profiles_state.h"

#include "chrome/common/extensions/api/tabs.h"

#include "url/gurl.h"

@@ -21,7 +22,9 @@ void ExtensionTabUtilDelegateChromeOS::ScrubTabForExtension(

const Extension* extension,

content::WebContents* contents,

api::tabs::Tab* tab) {

- if (!profiles::IsPublicSession() || !tab->url) {

+ if (!profiles::IsPublicSession() || !tab->url ||

+ chromeos::DeviceLocalAccountManagementPolicyProvider::IsWhitelisted(

+ extension->id())) {

return;

}

// Scrub URL down to the origin (security reasons inside Public Sessions).