Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: extensions/renderer/argument_spec.cc

Issue 2858633004: [Extensions Bindings] Fix uninitialized member in ArgumentSpec (Closed)
Patch Set: d'oh Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/argument_spec.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/argument_spec.cc
diff --git a/extensions/renderer/argument_spec.cc b/extensions/renderer/argument_spec.cc
index 5f6b619fe7801b8c3acd498203106f4e6ac137e8..cab45e9b14e99bdb7656af44343791472b2fb50e 100644
--- a/extensions/renderer/argument_spec.cc
+++ b/extensions/renderer/argument_spec.cc
@@ -72,8 +72,7 @@ bool CheckFundamentalBounds(T value,
} // namespace
-ArgumentSpec::ArgumentSpec(const base::Value& value)
- : type_(ArgumentType::INTEGER), optional_(false), preserve_null_(false) {
+ArgumentSpec::ArgumentSpec(const base::Value& value) {
const base::DictionaryValue* dict = nullptr;
CHECK(value.GetAsDictionary(&dict));
dict->GetBoolean("optional", &optional_);
@@ -82,7 +81,7 @@ ArgumentSpec::ArgumentSpec(const base::Value& value)
InitializeType(dict);
}
-ArgumentSpec::ArgumentSpec(ArgumentType type) : type_(type), optional_(false) {}
+ArgumentSpec::ArgumentSpec(ArgumentType type) : type_(type) {}
void ArgumentSpec::InitializeType(const base::DictionaryValue* dict) {
std::string ref_string;
« no previous file with comments | « extensions/renderer/argument_spec.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698