runtime/vm/regexp_assembler_ir.cc - Issue 2858623002: Remove MIPS support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp_assembler_ir.cc

Issue 2858623002: Remove MIPS support (Closed)

Patch Set: Merge and cleanup Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/regexp_assembler_ir.cc

diff --git a/runtime/vm/regexp_assembler_ir.cc b/runtime/vm/regexp_assembler_ir.cc

index 2bdc701b8315cd222701a57599d7709d829dae86..cecc3a653f534f2b9946eca717d5796caf79fb77 100644

--- a/runtime/vm/regexp_assembler_ir.cc

+++ b/runtime/vm/regexp_assembler_ir.cc

@@ -302,8 +302,7 @@ void IRRegExpMacroAssembler::FinalizeRegistersArray() {

}

-#if defined(TARGET_ARCH_ARM64) || defined(TARGET_ARCH_ARM) || \

- defined(TARGET_ARCH_MIPS)

+#if defined(TARGET_ARCH_ARM64) || defined(TARGET_ARCH_ARM)

// Disabling unaligned accesses forces the regexp engine to load characters one

// by one instead of up to 4 at once, along with the associated performance hit.

// TODO(zerny): Be less conservative about disabling unaligned accesses.

« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/runtime_entry.h » ('j') | no next file with comments »