third_party/tcmalloc/README.dart - Issue 2858623002: Remove MIPS support

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/tcmalloc/README.dart

Issue 2858623002: Remove MIPS support (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« build/config/gcc/gcc_version.gni ('K') | « third_party/pkg_tested/pkg_tested.status ('k') | tools/build.py » ('j') | no next file with comments »

OLD	NEW
1 Dart uses tcmalloc in the standalone VM on Linux.	1 Dart uses tcmalloc in the standalone VM on Linux.

2	2

3 To roll tcmalloc forward:	3 To roll tcmalloc forward:

4 . Clone the gperftools git repo at the revision you want in a directory off	4 . Clone the gperftools git repo at the revision you want in a directory off

5 to the side.	5 to the side.

6	6

7 . Run a configure command similar to the one in the configure_command file in	7 . Run a configure command similar to the one in the configure_command file in

8 this directory. It is up to you to determine if different flags are required	8 this directory. It is up to you to determine if different flags are required

9 for the newer gperftools.	9 for the newer gperftools.

10	10

11 . From that repo, copy src/config.h and src/gperftools/tcmalloc.h, and any other	11 . From that repo, copy src/config.h and src/gperftools/tcmalloc.h, and any other

12 generated header files to the include/ directory in this directory.	12 generated header files to the include/ directory in this directory.

13	13

14 . Also copy the COPYING file and any other relevant licensing information.	14 . Also copy the COPYING file and any other relevant licensing information.

15	15

16 . Make sure that include/config.h defines HAVE_UCONTEXT_H on Linux,	16 . Make sure that include/config.h defines HAVE_UCONTEXT_H on Linux,

17	17

18 . Update tcmalloc_sources.gypi, and tcmalloc.gyp if necessary. This may require	18 . Update tcmalloc_sources.gypi, and tcmalloc.gyp if necessary. This may require

19 inspecting gperftools/Makefile.am to see any additional source files and	19 inspecting gperftools/Makefile.am to see any additional source files and

20 preprocessor defines (-D flags).	20 preprocessor defines (-D flags).

21	21

22 . Update the DEPS file with the new git hash.	22 . Update the DEPS file with the new git hash.

23	23

24 . Build and run tests for Debug, Release, and Product builds for ia32, x64, mips	24 . Build and run tests for Debug, Release, and Product builds for ia32, x64,

25 and arm for Linux and any other OSs that are supported.	25 and arm for Linux and any other OSs that are supported.

OLD	NEW