Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: third_party/WebKit/Source/platform/wtf/Assertions.h

Issue 2858613002: Remove obsolete ASSERT_NOT_REACHED (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/wtf/Assertions.h
diff --git a/third_party/WebKit/Source/platform/wtf/Assertions.h b/third_party/WebKit/Source/platform/wtf/Assertions.h
index fcfbc94b3554bfa012deee9da144f7f69ef189fe..53f227793b93f8104d4c517cce3a12fb297b2167 100644
--- a/third_party/WebKit/Source/platform/wtf/Assertions.h
+++ b/third_party/WebKit/Source/platform/wtf/Assertions.h
@@ -123,12 +123,11 @@ class WTF_EXPORT ScopedLogger {
#define CRASH() IMMEDIATE_CRASH()
#endif
-// ASSERT and ASSERT_NOT_REACHED
+// ASSERT
// These macros are compiled out of release builds.
// Expressions inside them are evaluated in debug builds only.
-// They are deprecated. We should use:
+// This is deprecated. We should use:
// - DCHECK() for ASSERT()
-// - NOTREACHED() for ASSERT_NOT_REACHED()
#if OS(WIN)
// FIXME: Change to use something other than ASSERT to avoid this conflict with
// the underlying platform.
@@ -141,10 +140,8 @@ class WTF_EXPORT ScopedLogger {
#if DCHECK_IS_ON()
#define ASSERT(assertion) DCHECK(assertion)
-#define ASSERT_NOT_REACHED() NOTREACHED()
#else
#define ASSERT(assertion) ((void)0)
-#define ASSERT_NOT_REACHED() ((void)0)
#endif
// Users must test "#if ENABLE(SECURITY_ASSERT)", which helps ensure
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698