Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Unified Diff: chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java

Issue 2858563004: Add support for webapk without runtimeHost (Closed)
Patch Set: Nits. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
diff --git a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java b/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
index 2b16dd749c02958e0d857a5ce59ced9a8ebb7a29..2bf97d8e13f16610d4c819062dd4ca25c4f99dc8 100644
--- a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
+++ b/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
@@ -10,6 +10,7 @@ import android.content.pm.PackageManager;
import android.os.Looper;
import android.util.Log;
+import org.chromium.webapk.lib.common.WebApkConstants;
import org.chromium.webapk.lib.common.WebApkVersionUtils;
import java.io.File;
@@ -21,11 +22,6 @@ import java.util.Scanner;
public class HostBrowserClassLoader {
private static final String TAG = "cr_HostBrowserClassLoader";
- /**
- * Name of the shared preferences file.
- */
- private static final String PREF_PACKAGE = "org.chromium.webapk.shell_apk";
-
/**
* Name of the shared preference for Chrome's version code.
*/
@@ -77,7 +73,7 @@ public class HostBrowserClassLoader {
public static ClassLoader createClassLoader(
Context context, Context remoteContext, DexLoader dexLoader, String canaryClassName) {
SharedPreferences preferences =
- context.getSharedPreferences(PREF_PACKAGE, Context.MODE_PRIVATE);
+ context.getSharedPreferences(WebApkConstants.PREF_PACKAGE, Context.MODE_PRIVATE);
int runtimeDexVersion = preferences.getInt(RUNTIME_DEX_VERSION_PREF, -1);
int newRuntimeDexVersion = checkForNewRuntimeDexVersion(preferences, remoteContext);
@@ -104,7 +100,7 @@ public class HostBrowserClassLoader {
// WebAPK may still be running when the host browser gets upgraded. Prevent ClassLoader from
// getting reused in this scenario.
SharedPreferences preferences =
- context.getSharedPreferences(PREF_PACKAGE, Context.MODE_PRIVATE);
+ context.getSharedPreferences(WebApkConstants.PREF_PACKAGE, Context.MODE_PRIVATE);
int cachedRemoteVersionCode = preferences.getInt(REMOTE_VERSION_CODE_PREF, -1);
int remoteVersionCode = getVersionCode(remoteContext);
return remoteVersionCode == cachedRemoteVersionCode;

Powered by Google App Engine
This is Rietveld 408576698