Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2858563004: Add support for webapk without runtimeHost (Closed)
Patch Set: Delete private data before switching host browser. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 <!-- TODO(crbug.com/635567): Fix this properly. --> 433 <!-- TODO(crbug.com/635567): Fix this properly. -->
434 <ignore regexp="content/shell/android/shell_apk/res/layout/content_shell_act ivity.xml"/> 434 <ignore regexp="content/shell/android/shell_apk/res/layout/content_shell_act ivity.xml"/>
435 <!-- TODO(crbug.com/635567): Fix this properly. --> 435 <!-- TODO(crbug.com/635567): Fix this properly. -->
436 <ignore regexp="content/shell/android/linker_test_apk/res/layout/test_activi ty.xml"/> 436 <ignore regexp="content/shell/android/linker_test_apk/res/layout/test_activi ty.xml"/>
437 <!-- TODO(crbug.com/635567): Fix this properly. --> 437 <!-- TODO(crbug.com/635567): Fix this properly. -->
438 <ignore regexp="content/shell/android/shell_apk/res/values/strings.xml"/> 438 <ignore regexp="content/shell/android/shell_apk/res/values/strings.xml"/>
439 </issue> 439 </issue>
440 <issue id="UseCompoundDrawables"> 440 <issue id="UseCompoundDrawables">
441 <!-- Upscaling 24dp to 48dp doesn't work as expected with a TextView compoun d drawable. --> 441 <!-- Upscaling 24dp to 48dp doesn't work as expected with a TextView compoun d drawable. -->
442 <ignore regexp="chrome/android/java/res/layout/photo_picker_bitmap_view.xml" /> 442 <ignore regexp="chrome/android/java/res/layout/photo_picker_bitmap_view.xml" />
443 <ignore regexp="chrome/android/webapk/shell_apk/res/layout/choose_host_brows er_dialog_list.xml"/>
443 </issue> 444 </issue>
444 <issue id="UselessParent"> 445 <issue id="UselessParent">
445 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/> 446 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/>
446 <ignore regexp="chrome/android/java/res/layout/data_usage_breakdown.xml"/> 447 <ignore regexp="chrome/android/java/res/layout/data_usage_breakdown.xml"/>
447 <ignore regexp="chromecast/internal"/> 448 <ignore regexp="chromecast/internal"/>
448 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml"/> 449 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml"/>
449 </issue> 450 </issue>
450 <issue id="UsesMinSdkAttributes" severity="Error"> 451 <issue id="UsesMinSdkAttributes" severity="Error">
451 <ignore regexp="AndroidManifest.xml"/> 452 <ignore regexp="AndroidManifest.xml"/>
452 </issue> 453 </issue>
453 <issue id="ValidFragment" severity="Error"> 454 <issue id="ValidFragment" severity="Error">
454 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java"/> 455 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java"/>
455 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java"/> 456 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java"/>
456 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java"/> 457 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java"/>
457 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java"/> 458 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java"/>
458 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/> 459 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/>
459 </issue> 460 </issue>
460 <issue id="ViewConstructor" severity="ignore"/> 461 <issue id="ViewConstructor" severity="ignore"/>
461 <issue id="VisibleForTests" severity="Error"> 462 <issue id="VisibleForTests" severity="Error">
462 <ignore regexp="chrome/android/javatests"/> 463 <ignore regexp="chrome/android/javatests"/>
463 <ignore regexp="/test/"/> 464 <ignore regexp="/test/"/>
464 </issue> 465 </issue>
465 <issue id="WrongCall" severity="ignore"/> 466 <issue id="WrongCall" severity="ignore"/>
466 <issue id="WrongConstant"> 467 <issue id="WrongConstant">
467 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 468 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
468 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/> 469 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorView.java"/>
469 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 470 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
470 </issue> 471 </issue>
471 </lint> 472 </lint>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698