Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2858563004: Add support for webapk without runtimeHost (Closed)
Patch Set: Ted@'s comments and add "Unsupported by ..." strings for browser not supporting webapks. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 <!-- TODO(crbug.com/635567): Fix this properly. --> 426 <!-- TODO(crbug.com/635567): Fix this properly. -->
427 <ignore regexp="content/shell/android/shell_apk/res/layout/content_shell_act ivity.xml"/> 427 <ignore regexp="content/shell/android/shell_apk/res/layout/content_shell_act ivity.xml"/>
428 <!-- TODO(crbug.com/635567): Fix this properly. --> 428 <!-- TODO(crbug.com/635567): Fix this properly. -->
429 <ignore regexp="content/shell/android/linker_test_apk/res/layout/test_activi ty.xml"/> 429 <ignore regexp="content/shell/android/linker_test_apk/res/layout/test_activi ty.xml"/>
430 <!-- TODO(crbug.com/635567): Fix this properly. --> 430 <!-- TODO(crbug.com/635567): Fix this properly. -->
431 <ignore regexp="content/shell/android/shell_apk/res/values/strings.xml"/> 431 <ignore regexp="content/shell/android/shell_apk/res/values/strings.xml"/>
432 </issue> 432 </issue>
433 <issue id="UseCompoundDrawables"> 433 <issue id="UseCompoundDrawables">
434 <!-- Upscaling 24dp to 48dp doesn't work as expected with a TextView compoun d drawable. --> 434 <!-- Upscaling 24dp to 48dp doesn't work as expected with a TextView compoun d drawable. -->
435 <ignore regexp="chrome/android/java/res/layout/photo_picker_bitmap_view.xml" /> 435 <ignore regexp="chrome/android/java/res/layout/photo_picker_bitmap_view.xml" />
436 <ignore regexp="chrome/android/webapk/shell_apk/res/layout/choose_host_brows er_dialog_list.xml"/>
agrieve 2017/06/05 20:34:20 Would using tools:ignore= work for suppressing thi
Xi Han 2017/06/05 20:43:50 Thanks! Didn't know this before.
436 </issue> 437 </issue>
437 <issue id="UselessParent"> 438 <issue id="UselessParent">
438 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/> 439 <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/ac tivity_webview_browser.xml"/>
439 <ignore regexp="chrome/android/java/res/layout/data_usage_breakdown.xml"/> 440 <ignore regexp="chrome/android/java/res/layout/data_usage_breakdown.xml"/>
440 <ignore regexp="chromecast/internal"/> 441 <ignore regexp="chromecast/internal"/>
441 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml"/> 442 <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activi ty_account_authenticator.xml"/>
442 </issue> 443 </issue>
443 <issue id="UsesMinSdkAttributes" severity="Error"> 444 <issue id="UsesMinSdkAttributes" severity="Error">
444 <ignore regexp="AndroidManifest.xml"/> 445 <ignore regexp="AndroidManifest.xml"/>
445 </issue> 446 </issue>
446 <issue id="ValidFragment" severity="Error"> 447 <issue id="ValidFragment" severity="Error">
447 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java"/> 448 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/BaseMediaRouteDialogManager.java"/>
448 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java"/> 449 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteChooserDialogManager.java"/>
449 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java"/> 450 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/ro uter/MediaRouteControllerDialogManager.java"/>
450 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java"/> 451 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferen ces/privacy/OtherFormsOfHistoryDialogFragment.java"/>
451 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/> 452 <ignore regexp="media/capture/content/android/java/src/org/chromium/media/Sc reenCapture.java"/>
452 </issue> 453 </issue>
453 <issue id="ViewConstructor" severity="ignore"/> 454 <issue id="ViewConstructor" severity="ignore"/>
454 <issue id="VisibleForTests" severity="Error"> 455 <issue id="VisibleForTests" severity="Error">
455 <ignore regexp="chrome/android/javatests"/> 456 <ignore regexp="chrome/android/javatests"/>
456 <ignore regexp="/test/"/> 457 <ignore regexp="/test/"/>
457 </issue> 458 </issue>
458 <issue id="WrongCall" severity="ignore"/> 459 <issue id="WrongCall" severity="ignore"/>
459 <issue id="WrongConstant"> 460 <issue id="WrongConstant">
460 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/> 461 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClien tCertificateRequest.java"/>
461 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorDialog.java"/> 462 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments /ui/EditorDialog.java"/>
462 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/> 463 <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/S igninAndSyncView.java"/>
463 </issue> 464 </issue>
464 </lint> 465 </lint>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698