chrome/android/webapk/shell_apk/res/color/item_selection_text_color.xml - Issue 2858563004: Add support for webapk without runtimeHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/webapk/shell_apk/res/color/item_selection_text_color.xml

Issue 2858563004: Add support for webapk without runtimeHost (Closed)

Patch Set: Nits. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/WebApkUtilsTest.java ('k') | chrome/android/webapk/shell_apk/res/layout/choose_host_browser_dialog.xml » ('j') | chrome/android/webapk/shell_apk/res/layout/choose_host_browser_dialog.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Ted C 2017/06/05 18:24:48 did you try: https://developer.android.com/referen did you try: https://developer.android.com/reference/android/R.color.html#primary_text_dark or https://developer.android.com/reference/android/R.color.html#primary_text_light They might be indistinguishable if you want to eke a tiny bit of improvement. Xi Han 2017/06/05 20:30:02 The primary_text_dark looks too light for the enab Show quoted text On 2017/06/05 18:24:48, Ted C wrote: > did you try: > https://developer.android.com/reference/android/R.color.html#primary_text_dark > or > https://developer.android.com/reference/android/R.color.html#primary_text_light > > They might be indistinguishable if you want to eke a tiny bit of improvement. The primary_text_dark looks too light for the enabled text, and black looks closer to the color in the UI review(https://docs.google.com/presentation/d/1ZC7Fc9Y7-vsGqvbEyiZmiJoWtsONkhPBUb47F0s4u4s/edit#slide=id.g1ca70aafc8_0_16). However, it seems using @android:color/primary_text_light can't change the color of the disabled text which is still black. So I remove this xml, and just set the text color programmatically.
	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <selector xmlns:android="http://schemas.android.com/apk/res/android">

	7 <item android:state_enabled="false" android:color="#808080" />

	8 <item android:color="#000000"/>

	9 </selector>

OLD	NEW