Add BackendStrategy

Add BackendStrategy

This strategy pattern defines the element model used in type inference and codegen.
This allows for creating an element model for the backend that is different from
the frontend model.

R=efortuna@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/08474aecdfb90db76726518d6f4e1cdfa807a28f

[Johnni Winther, 2017-05-02 08:57:00]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Emily Fortuna, 2017-05-02 18:06:39]

efortuna@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-05-02 18:06:40]

lgtm

https://codereview.chromium.org/2858513002/diff/20001/pkg/compiler/lib/src/ba...
File pkg/compiler/lib/src/backend_strategy.dart (right):

https://codereview.chromium.org/2858513002/diff/20001/pkg/compiler/lib/src/ba...
pkg/compiler/lib/src/backend_strategy.dart:18: void
createClosureClasses(ClosedWorldRefiner closedWorldRefiner);
this name is still in line with the "old way" of thinking about creating
closures in terms of fake elements. Perhaps we should just call this function
"rewriteClosures" or "convertClosures" or something instead?

[Siggi Cherem (dart-lang), 2017-05-02 20:13:17]

lgtm

https://codereview.chromium.org/2858513002/diff/20001/pkg/compiler/lib/src/ba...
File pkg/compiler/lib/src/backend_strategy.dart (right):

https://codereview.chromium.org/2858513002/diff/20001/pkg/compiler/lib/src/ba...
pkg/compiler/lib/src/backend_strategy.dart:18: void
createClosureClasses(ClosedWorldRefiner closedWorldRefiner);
On 2017/05/02 18:06:39, Emily Fortuna wrote:
> this name is still in line with the "old way" of thinking about creating
> closures in terms of fake elements. Perhaps we should just call this function
> "rewriteClosures" or "convertClosures" or something instead?

+1 :)

[Johnni Winther, 2017-05-03 08:24:50]

Description was changed from

==========
Add BackendStrategy

This strategy pattern defines the element model used in type inference and
codegen.
This allows for creating an element model for the backend that is different from
the frontend model.
==========

to

==========
Add BackendStrategy

This strategy pattern defines the element model used in type inference and
codegen.
This allows for creating an element model for the backend that is different from
the frontend model.

R=efortuna@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/08474aecdfb90db76726518d6f4e1cdfa807a28f
==========

[Johnni Winther, 2017-05-03 08:24:51]

Committed patchset #3 (id:40001) manually as
08474aecdfb90db76726518d6f4e1cdfa807a28f (presubmit successful).

[Johnni Winther, 2017-05-03 08:25:44]

https://codereview.chromium.org/2858513002/diff/20001/pkg/compiler/lib/src/ba...
File pkg/compiler/lib/src/backend_strategy.dart (right):

https://codereview.chromium.org/2858513002/diff/20001/pkg/compiler/lib/src/ba...
pkg/compiler/lib/src/backend_strategy.dart:18: void
createClosureClasses(ClosedWorldRefiner closedWorldRefiner);
On 2017/05/02 18:06:39, Emily Fortuna wrote:
> this name is still in line with the "old way" of thinking about creating
> closures in terms of fake elements. Perhaps we should just call this function
> "rewriteClosures" or "convertClosures" or something instead?

[convertClosures] it is.