third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html - Issue 2858493002: Rename AXObject to AXObjectImpl in modules/ and web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html

Issue 2858493002: Rename AXObject to AXObjectImpl in modules/ and web/ (Closed)

Patch Set: Reverted unexpected change to blink rename merge helper Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash.html ('K') | « third_party/WebKit/LayoutTests/accessibility/display-none-change.html ('k') | third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles-expected.txt » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html

diff --git a/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html b/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html

index ce6751c4c88d7969598deaafb6891097a3d970ad..c79fe78beb74361f9528c1c8445af3ff6c7b73ea 100644

--- a/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html

+++ b/third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html

@@ -43,8 +43,8 @@ if (window.testRunner && window.accessibilityController) {

shouldBe("containerNode.childrenCount", "" + roles.length);

for (var i = 0; i < roles.length; i++) {

- var AXObject = containerNode.childAtIndex(i);

- shouldBe("AXObject.role", "'AXRole: " + roles[i] + "'");

+ var AXObjectImpl = containerNode.childAtIndex(i);

aboxhall 2017/05/05 05:22:18 Similarly, no need to be specific re -Impl here.

+ shouldBe("AXObjectImpl.role", "'AXRole: " + roles[i] + "'");

}

</script>