js_runtime: Split _asyncHelper into separate functions

js_runtime: Split _asyncHelper into separate functions

The separate functions have smaller call-sites and less overhead.

_asyncStart uses Future._nullFuture to avoid 1 allocation.

BUG=
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/1472eba52d4364cb7bea83035c8f1b165fd843ca

[sra1, 2017-05-02 19:56:30]

Description was changed from

==========
js_runtime: Split _asyncHelper into separate functions

The separate functions have smaller call-sites and less overhead.

BUG=
==========

to

==========
js_runtime: Split _asyncHelper into separate functions

The separate functions have smaller call-sites and less overhead.

_asyncStart uses Future._nullFuture to avoid 1 allocation.

BUG=
==========

[sra1, 2017-05-02 19:56:30]

sra@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-05-03 10:14:25]

LGTM.

https://codereview.chromium.org/2858463002/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/2858463002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js/rewrite_async.dart:1666: /// Function called by the
async function so simulate an `await`
to

https://codereview.chromium.org/2858463002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js/rewrite_async.dart:1670: /// - The body function
[bodyname]
why that change?
in the comment above it's still "bodyName".

https://codereview.chromium.org/2858463002/diff/40001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/async_patch.dart (right):

https://codereview.chromium.org/2858463002/diff/40001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/async_patch.dart:133: /// Runtime support for
the async-await transformation. Initiates the
The first sentence should say what the function does. It should also be a simple
sentence (and not a three line paragraph).

See below for a suggestion on how to format the doc.

https://codereview.chromium.org/2858463002/diff/40001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/async_patch.dart:154: /// Runtime support for
the async-await transformation. Returns [object] from
Starting a sentence with "Returns" in a dartdoc puts me in "this function
returns" mode.

Maybe:

"""
Completes the future of the `async` function.

Used as part of the runtime support for the async/await transformation.

This function is used when the `async` function returns (explicitly or
implicitly).
"""

[sra1, 2017-05-03 17:12:20]

Thanks for the comments

https://codereview.chromium.org/2858463002/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/2858463002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js/rewrite_async.dart:1666: /// Function called by the
async function so simulate an `await`
On 2017/05/03 10:14:25, floitsch wrote:
> to

Done.

https://codereview.chromium.org/2858463002/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js/rewrite_async.dart:1670: /// - The body function
[bodyname]
On 2017/05/03 10:14:25, floitsch wrote:
> why that change?
> in the comment above it's still "bodyName".

Done.

https://codereview.chromium.org/2858463002/diff/40001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/async_patch.dart (right):

https://codereview.chromium.org/2858463002/diff/40001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/async_patch.dart:133: /// Runtime support for
the async-await transformation. Initiates the
On 2017/05/03 10:14:25, floitsch wrote:
> The first sentence should say what the function does. It should also be a
simple
> sentence (and not a three line paragraph).
> 
> See below for a suggestion on how to format the doc.

Done.

https://codereview.chromium.org/2858463002/diff/40001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/async_patch.dart:154: /// Runtime support for
the async-await transformation. Returns [object] from
On 2017/05/03 10:14:25, floitsch wrote:
> Starting a sentence with "Returns" in a dartdoc puts me in "this function
> returns" mode.
> 
> Maybe:
> 
> """
> Completes the future of the `async` function.
> 
> Used as part of the runtime support for the async/await transformation.
> 
> This function is used when the `async` function returns (explicitly or
> implicitly).
> """

Done.

[sra1, 2017-05-03 19:38:46]

Description was changed from

==========
js_runtime: Split _asyncHelper into separate functions

The separate functions have smaller call-sites and less overhead.

_asyncStart uses Future._nullFuture to avoid 1 allocation.

BUG=
==========

to

==========
js_runtime: Split _asyncHelper into separate functions

The separate functions have smaller call-sites and less overhead.

_asyncStart uses Future._nullFuture to avoid 1 allocation.

BUG=
R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1472eba52d4364cb7bea83035c8f1b165fd843ca
==========

[sra1, 2017-05-03 19:38:47]

Committed patchset #6 (id:100001) manually as
1472eba52d4364cb7bea83035c8f1b165fd843ca (presubmit successful).