Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2858423002: Disable style sharing outside tests. (Closed)

Created:
3 years, 7 months ago by esprehn
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable style sharing outside tests. This disables style sharing for most users in Canary, but leaves the code and leaves it enabled in the layout tests. Once this bakes for a little while we can then remove the code and update the tests. Per the style-dev@ discussion and design doc: https://groups.google.com/a/chromium.org/forum/#!topic/style-dev/8BV0QYubjos

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (6 generated)
esprehn
It seems some telemetry unit test is failing, and apparently only on android: https://cs.chromium.org/chromium/src/tools/perf/measurements/blink_style_unittest.py?rcl=2f3ad3b7b77d3a36922e42d3d3e5b1ad08a2a074&l=28 How ...
3 years, 7 months ago (2017-05-05 19:12:18 UTC) #7
nainar
3 years, 7 months ago (2017-05-08 01:29:55 UTC) #8
LGTM. 

No clue about the failing android telemetry test though. Tried grokking around
telemetry to see if I could see what failures could possibly be. Got nothing.
Would be interested in knowing what this is though.

Powered by Google App Engine
This is Rietveld 408576698