Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: media/audio/audio_unittest_util.h

Issue 2858383002: Move one test in an anonymous namespace. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_unittest_util.h
diff --git a/media/audio/audio_unittest_util.h b/media/audio/audio_unittest_util.h
index 3bd0dfad676c93109e845e076abd8b5191e47bb1..368bd305fb42348dae1d56bae8d03db51edbcb7a 100644
--- a/media/audio/audio_unittest_util.h
+++ b/media/audio/audio_unittest_util.h
@@ -7,28 +7,26 @@
#include "testing/gtest/include/gtest/gtest.h"
-namespace media {
-
// Use in tests to either skip or fail a test when the system is missing a
// required audio device or library. If the --require-audio-hardware-for-testing
// flag is set, missing requirements will cause the test to fail. Otherwise it
// will be skipped.
-#define ABORT_AUDIO_TEST_IF_NOT(requirements_satisfied) \
- do { \
- bool fail = false; \
- if (ShouldAbortAudioTest(requirements_satisfied, #requirements_satisfied, \
- &fail)) { \
- if (fail) \
- FAIL(); \
- else \
- return; \
- } \
+#define ABORT_AUDIO_TEST_IF_NOT(requirements_satisfied) \
+ do { \
+ bool fail = false; \
+ if (media::ShouldAbortAudioTest(requirements_satisfied, \
+ #requirements_satisfied, &fail)) { \
+ if (fail) \
+ FAIL(); \
+ else \
+ return; \
+ } \
} while (false)
+namespace media {
jrummell 2017/05/10 18:18:47 nit: Typically namespace statements have a blank l
bool ShouldAbortAudioTest(bool requirements_satisfied,
const char* requirements_expression,
bool* should_fail);
-
} // namespace media
#endif // MEDIA_AUDIO_AUDIO_UNITTEST_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698