Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/chromeos/printing/printers_manager.h

Issue 2858353004: Track printer installations for each configuration. (Closed)
Patch Set: address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/printing/printers_manager.h
diff --git a/chrome/browser/chromeos/printing/printers_manager.h b/chrome/browser/chromeos/printing/printers_manager.h
index f31bd6c7d0fd766ea22b6dbfa04392dd6a22b574..ee13a1b974ea05f7cb01f42e1aa3ff34f35fb33a 100644
--- a/chrome/browser/chromeos/printing/printers_manager.h
+++ b/chrome/browser/chromeos/printing/printers_manager.h
@@ -55,8 +55,8 @@ class PrintersManager : public KeyedService {
// printer exists.
std::unique_ptr<Printer> GetPrinter(const std::string& printer_id) const;
- // Adds or updates a printer. Printers are identified by the id field. Use an
- // empty id to add a new printer.
+ // Add or update a printer in profile preferences. Printers are identified by
Lei Zhang 2017/05/09 01:14:39 BTW, most of the other comments say "Returns" so k
skau 2017/05/09 19:39:27 Done.
+ // the id field. Use an empty id to add a new printer.
void RegisterPrinter(std::unique_ptr<Printer> printer);
// Remove printer from preferences with the id |printer_id|. Returns true if
@@ -76,6 +76,13 @@ class PrintersManager : public KeyedService {
// Returns a ModelTypeSyncBridge for the sync client.
PrintersSyncBridge* GetSyncBridge();
+ // Registers that the printer was installed in CUPS. This is independent of
+ // whether a printer is saved in profile preferences.
+ void PrinterInstalled(const Printer& printer);
+
+ // Returns true if |printer| is currently installed in CUPS.
+ bool IsConfigurationCurrent(const Printer& printer) const;
+
private:
// Updates the in-memory recommended printer list.
void UpdateRecommendedPrinters();
@@ -89,8 +96,10 @@ class PrintersManager : public KeyedService {
// Contains the keys for all recommended printers in order so we can return
// the list of recommended printers in the order they were received.
std::vector<std::string> recommended_printer_ids_;
- std::map<std::string, std::unique_ptr<base::DictionaryValue>>
- recommended_printers_;
+ std::map<std::string, std::unique_ptr<Printer>> recommended_printers_;
+
+ // Map of printer ids to installation timestamps.
+ std::map<std::string, base::Time> installed_printer_timestamps_;
base::ObserverList<Observer> observers_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/printing/printers_manager.cc » ('j') | chromeos/printing/printer_translator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698