Move Dart versions of math.min() and math.max() into VM patch file.

Move Dart versions of math.min() and math.max() into VM patch file.

For DDC and dart2js, we call the corresponding JS function. This is
shorter and avoids a strong mode type error in the Dart implementation.

R=jmesserly@google.com, lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/4145a495033413054e16a32ef2689e69b02182e3

[Bob Nystrom, 2017-05-04 21:49:10]

rnystrom@google.com changed reviewers:
+ jmesserly@google.com, lrn@google.com

[Jennifer Messerly, 2017-05-04 22:13:06]

lgtm on DDC side

[Lasse Reichstein Nielsen, 2017-05-05 06:23:25]

https://codereview.chromium.org/2858353003/diff/1/sdk/lib/math/math.dart
File sdk/lib/math/math.dart (right):

https://codereview.chromium.org/2858353003/diff/1/sdk/lib/math/math.dart#newc...
sdk/lib/math/math.dart:78: external T min<T extends num>(T a, T b);
I think this'll be the first patched generic method, so let's make sure we have
good test coverage of it, including the genericity (which we probably don't).

[Lasse Reichstein Nielsen, 2017-05-05 06:23:39]

But otherwise LGTM

[sra1, 2017-05-05 07:08:22]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-05-05 07:08:23]

https://codereview.chromium.org/2858353003/diff/1/runtime/lib/math_patch.dart
File runtime/lib/math_patch.dart (right):

https://codereview.chromium.org/2858353003/diff/1/runtime/lib/math_patch.dart...
runtime/lib/math_patch.dart:13: // return type.
Fix this comment to say the VM version is this way for *compatibility with*
dart2js.

https://codereview.chromium.org/2858353003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/math_patch.dart (right):

https://codereview.chromium.org/2858353003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/math_patch.dart:12: JS('num', r'Math.min(#,
#)', checkNum(a), checkNum(b)) as T;
I *believe* this has the same behaviour, but are we sure?
i.e. do the corelib tests cover all weird cases, including all combinations of
0, -0.0, NaN, +Inf, -Inf with each other and with other numbers?

[Lasse Reichstein Nielsen, 2017-05-05 07:38:51]

https://codereview.chromium.org/2858353003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/math_patch.dart (right):

https://codereview.chromium.org/2858353003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/math_patch.dart:12: JS('num', r'Math.min(#,
#)', checkNum(a), checkNum(b)) as T;
It works correctly.
It's simpler than the VM version because it doesn't have to compare integers and
doubles.
For doubles, the ordering is pretty simple: NaN always wins, -0.0 is smaller
than +0.0, and the rest are ordered by simple '<' of the values. JS does that
the same way as Dart.

[Bob Nystrom, 2017-05-05 22:12:17]

On 2017/05/05 06:23:25, Lasse Reichstein Nielsen wrote:
> https://codereview.chromium.org/2858353003/diff/1/sdk/lib/math/math.dart
> File sdk/lib/math/math.dart (right):
> 
>
https://codereview.chromium.org/2858353003/diff/1/sdk/lib/math/math.dart#newc...
> sdk/lib/math/math.dart:78: external T min<T extends num>(T a, T b);
> I think this'll be the first patched generic method, so let's make sure we
have
> good test coverage of it, including the genericity (which we probably don't).

I think we do have OK test coverage of the general behavior. As far as I can
tell, there's no tests of its genericity.

I'm not sure how I'd go about that. Is that something you can give me a hand
with?

[Bob Nystrom, 2017-05-05 22:15:27]

Description was changed from

==========
Move Dart versions of math.min() and math.max() into VM patch file.

For DDC and dart2js, we call the corresponding JS function. This is
shorter and avoids a strong mode type error in the Dart implementation.
==========

to

==========
Move Dart versions of math.min() and math.max() into VM patch file.

For DDC and dart2js, we call the corresponding JS function. This is
shorter and avoids a strong mode type error in the Dart implementation.

R=jmesserly@google.com, lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4145a495033413054e16a32ef2689e69b02182e3
==========

[Bob Nystrom, 2017-05-05 22:15:28]

Committed patchset #3 (id:20001) manually as
4145a495033413054e16a32ef2689e69b02182e3 (presubmit successful).