MediaPerceptionPrivate API impl and testing.

extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc

Index: extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc
diff --git a/extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc b/extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..df45c49e4033555d7a1c981c4490d3fe54924e3a
--- /dev/null
+++ b/extensions/browser/api/media_perception_private/media_perception_api_manager_unittest.cc
@@ -0,0 +1,142 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/browser/api/media_perception_private/media_perception_api_manager.h"
+
+#include "base/bind.h"
+#include "base/memory/ptr_util.h"
+#include "base/run_loop.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/fake_media_analytics_client.h"
+#include "chromeos/dbus/fake_upstart_client.h"
+#include "chromeos/dbus/media_analytics_client.h"
+#include "chromeos/dbus/test_upstart_client.h"
+#include "chromeos/dbus/upstart_client.h"
+#include "content/public/test/test_browser_context.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace media_perception = extensions::api::media_perception_private;
+
+namespace extensions {
+
+using CallbackStatus = MediaPerceptionAPIManager::CallbackStatus;
+
+namespace {
+
+void StallStateCallback(CallbackStatus result_status,
+                        media_perception::State result_state) {}
+
+void RecordStatusAndRunClosure(base::Closure quit_run_loop,
+                               CallbackStatus* status,
+                               CallbackStatus result_status,
+                               media_perception::State result_state) {
+  *status = result_status;
+  quit_run_loop.Run();
+}
+
+CallbackStatus SetState(MediaPerceptionAPIManager* manager,

[tbarzic, 2017/05/18 21:39:15]

nit: consider renaming this to SetStateAndWaitForResponse

(same with GetState)

[Luke Sorenson, 2017/05/19 00:56:43]

Done.

+                        const media_perception::State& state) {
+  base::RunLoop run_loop;
+  CallbackStatus status;
+  manager->SetState(state, base::Bind(&RecordStatusAndRunClosure,
+                                      run_loop.QuitClosure(), &status));
+  run_loop.Run();
+  return status;
+}
+
+CallbackStatus GetState(MediaPerceptionAPIManager* manager) {
+  base::RunLoop run_loop;
+  CallbackStatus status;
+  manager->GetState(
+      base::Bind(&RecordStatusAndRunClosure, run_loop.QuitClosure(), &status));
+  run_loop.Run();
+  return status;
+}
+
+}  // namespace
+
+class MediaPerceptionAPIManagerTest : public testing::Test {
+ public:
+  MediaPerceptionAPIManagerTest()
+      : thread_bundle_(content::TestBrowserThreadBundle::DEFAULT) {}
+
+  void SetUp() override {
+    std::unique_ptr<chromeos::DBusThreadManagerSetter> dbus_setter =
+        chromeos::DBusThreadManager::GetSetterForTesting();
+    auto media_analytics_client =
+        base::MakeUnique<chromeos::FakeMediaAnalyticsClient>();
+    media_analytics_client_ = media_analytics_client.get();
+    dbus_setter->SetMediaAnalyticsClient(std::move(media_analytics_client));
+
+    auto upstart_client = base::MakeUnique<chromeos::TestUpstartClient>();
+    upstart_client_ = upstart_client.get();
+    dbus_setter->SetUpstartClient(std::move(upstart_client));
+
+    manager_ = base::MakeUnique<MediaPerceptionAPIManager>(&browser_context_);
+  }
+
+  void TearDown() override {
+    // Need to make sure that the MediaPerceptionAPIManager is destructed before
+    // the DbusThreadManager.
+    manager_.reset();
+    chromeos::DBusThreadManager::Shutdown();
+  }
+
+  std::unique_ptr<MediaPerceptionAPIManager> manager_;
+  content::TestBrowserContext browser_context_;
+  content::TestBrowserThreadBundle thread_bundle_;
+
+  // Ownership of both is passed on to chromeos::DbusThreadManager.
+  chromeos::FakeMediaAnalyticsClient* media_analytics_client_;
+  chromeos::TestUpstartClient* upstart_client_;
+
+  DISALLOW_COPY_AND_ASSIGN(MediaPerceptionAPIManagerTest);
+};
+
+TEST_F(MediaPerceptionAPIManagerTest, UpstartFailure) {
+  media_perception::State state;
+  state.status = media_perception::STATUS_RUNNING;
+  base::RunLoop run_loop;
+  CallbackStatus status;
+  manager_->SetState(state, base::Bind(&RecordStatusAndRunClosure,
+                                       run_loop.QuitClosure(), &status));
+  EXPECT_TRUE(upstart_client_->HandleNextUpstartRequest(false));
+  run_loop.Run();
+  EXPECT_EQ(CallbackStatus::PROCESS_IDLE_ERROR, status);
+}
+
+TEST_F(MediaPerceptionAPIManagerTest, UpstartStall) {
+  media_perception::State state;
+  state.status = media_perception::STATUS_RUNNING;
+  // This call will stall so we don't wait for it to get callback.
+  manager_->SetState(state, base::Bind(&StallStateCallback));

[tbarzic, 2017/05/18 21:39:15]

Pass in RecordStatusAndRunClosure, and make sure this returns when you call
HandleNextUpstartRequest

[Luke Sorenson, 2017/05/19 00:56:43]

Done.

+  EXPECT_EQ(CallbackStatus::PROCESS_LAUNCHING_ERROR, GetState(manager_.get()));
+  EXPECT_EQ(CallbackStatus::PROCESS_LAUNCHING_ERROR,
+            SetState(manager_.get(), state));
+  EXPECT_TRUE(upstart_client_->HandleNextUpstartRequest(true));
+  // Verify that after the slow start, things works as normal.
+  EXPECT_EQ(CallbackStatus::SUCCESS, GetState(manager_.get()));
+  state.status = media_perception::STATUS_SUSPENDED;
+  EXPECT_EQ(CallbackStatus::SUCCESS, SetState(manager_.get(), state));
+}
+
+TEST_F(MediaPerceptionAPIManagerTest, MediaAnalyticsDbusError) {
+  // Use FakeUpstartClient in this case because we don't need to override the
+  // StartMediaAnalytics behavior.
+  std::unique_ptr<chromeos::DBusThreadManagerSetter> dbus_setter =
+      chromeos::DBusThreadManager::GetSetterForTesting();
+  auto upstart_client = base::MakeUnique<chromeos::FakeUpstartClient>();

[tbarzic, 2017/05/18 21:39:15]

Can you use TestUpstartClient here as well (but have it respond automatically)

TestUpstartClient : public FakeUpstartClient {

  // Call this from UpstartStall/UpstartFailure
  void set_enqueue_requests(bool enqueue_requests) {enqueue_requests_ =
enqueue_requests; }
 private:
  bool enqueue_requests_ = false;
}


Or just don't use SetState in this test.

[Luke Sorenson, 2017/05/19 00:56:43]

Done.

+  dbus_setter->SetUpstartClient(std::move(upstart_client));
+
+  media_perception::State state;
+  state.status = media_perception::STATUS_RUNNING;
+  EXPECT_EQ(CallbackStatus::SUCCESS, SetState(manager_.get(), state));
+  // Disable the functionality of the fake process.
+  media_analytics_client_->set_process_running(false);
+  EXPECT_EQ(CallbackStatus::DBUS_ERROR, GetState(manager_.get()));
+  EXPECT_EQ(CallbackStatus::DBUS_ERROR, SetState(manager_.get(), state));
+}
+
+}  // namespace extensions