chromeos/dbus/fake_upstart_client.h - Issue 2858353002: MediaPerceptionPrivate API impl and testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_upstart_client.h

Issue 2858353002: MediaPerceptionPrivate API impl and testing. (Closed)

Patch Set: Addressed comments (added TestUpstartClient). Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/fake_upstart_client.h

diff --git a/chromeos/dbus/fake_upstart_client.h b/chromeos/dbus/fake_upstart_client.h

index efcb5e6a6c1344b3e19a417dd0bd3e667b7c182e..299cba122ccfffe33cc5f385e4af696c304cea59 100644

--- a/chromeos/dbus/fake_upstart_client.h

+++ b/chromeos/dbus/fake_upstart_client.h

@@ -6,7 +6,6 @@

#define CHROMEOS_DBUS_FAKE_UPSTART_CLIENT_H_

#include "base/macros.h"

#include "chromeos/dbus/upstart_client.h"

namespace chromeos {

@@ -25,7 +24,6 @@ class CHROMEOS_EXPORT FakeUpstartClient : public UpstartClient {

void StartMediaAnalytics(const UpstartCallback& callback) override;

void StopMediaAnalytics() override;

- private:

tbarzic 2017/05/18 21:39:15 keep this

Luke Sorenson 2017/05/19 00:56:43 Done.

DISALLOW_COPY_AND_ASSIGN(FakeUpstartClient);

};