chromeos/dbus/proto/media_perception.proto - Issue 2858353002: MediaPerceptionPrivate API impl and testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/proto/media_perception.proto

Issue 2858353002: MediaPerceptionPrivate API impl and testing. (Closed)

Patch Set: Addressed comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/proto/media_perception.proto

diff --git a/chromeos/dbus/proto/media_perception.proto b/chromeos/dbus/proto/media_perception.proto

index c7b78704e12b2b167bee6c72492aed6a1386c3b7..4604a683f5b0e66ce15eec0554f3f0a703fa10f4 100644

--- a/chromeos/dbus/proto/media_perception.proto

+++ b/chromeos/dbus/proto/media_perception.proto

@@ -31,7 +31,6 @@ message Diagnostics {

message State {

enum Status {

STATUS_UNSPECIFIED = 0; // Unused required default value for Proto enums.

- TIMEOUT = 1; // Unable to reach media analysis process.

tbarzic 2017/05/18 19:28:01 Do you have to do this? Even if it's unused, it's

Luke Sorenson 2017/05/18 21:24:17 Sorry, forgot to adjust the numbers as well. Makin

UNINITIALIZED = 2; // Media analytics working on loading configuration.

STARTED = 3; // Analysis process running but not recieving frames.

RUNNING = 4; // Analysis process running and injesting frames.