MediaPerceptionPrivate API impl and testing.

extensions/browser/api/media_perception_private/media_perception_api_manager.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_API_MEDIA_PERCEPTION_PRIVATE_MEDIA_PERCEPTION_API_MANAGER_H_
+#define EXTENSIONS_BROWSER_API_MEDIA_PERCEPTION_PRIVATE_MEDIA_PERCEPTION_API_MANAGER_H_
+
+#include "base/memory/weak_ptr.h"
+#include "chromeos/media_perception/media_perception.pb.h"
+#include "extensions/browser/browser_context_keyed_api_factory.h"
+#include "extensions/common/api/media_perception_private.h"
+
+namespace media_perception = extensions::api::media_perception_private;
+
+namespace extensions {
+
+enum CallbackStatus {

[tbarzic, 2017/05/12 18:59:20]

use enum class

extension::CallbackStatus is very generic name - it can easily cause a naming
conflict
Can you make this public member of MediaPerceptionAPIManager

[Luke Sorenson, 2017/05/12 21:56:21]

Done.

+  // Request to media analytics process was successful.
+  SUCCESS,
+  // Request to media analytics process failed at D-Bus layer.
+  DBUS_ERROR,
+  // The media analytics process is not running.
+  PROCESS_IDLE,

[tbarzic, 2017/05/12 18:59:20]

nit: I'd add ERROR as name prefix or suffix - to make it clear it maps to an
error status :)

[Luke Sorenson, 2017/05/12 21:56:21]

Done.

+  // The media analytics process has been launched via Upstart, but waiting for
+  // callback to confirm.
+  PROCESS_LAUNCHING
+};
+
+namespace {
+
+enum AnalyticsProcessState {

[tbarzic, 2017/05/12 18:59:20]

enum class

also, make this private member of MediaPerceptionAPIManager

[Luke Sorenson, 2017/05/12 21:56:21]

Done.

+  // The process is not running.
+  IDLE,
+  // The process has been launched via Upstart, but waiting for callback to
+  // confirm.
+  LAUNCHING,
+  // The process is running.
+  RUNNING
+};
+}
+
+class MediaPerceptionAPIManager : public BrowserContextKeyedAPI {
+ public:
+  explicit MediaPerceptionAPIManager(content::BrowserContext* context);
+  ~MediaPerceptionAPIManager() override;
+
+  // Convenience method to get the MediaPeceptionAPIManager for a
+  // BrowserContext.
+  static MediaPerceptionAPIManager* Get(content::BrowserContext* context);
+
+  // BrowserContextKeyedAPI implementation.
+  static BrowserContextKeyedAPIFactory<MediaPerceptionAPIManager>*
+  GetFactoryInstance();
+
+  // Public functions for MediaPerceptionPrivateAPI implementation.
+  // Abstracts away D-Bus communication and underlying protos.
+  using APIStateCallback = base::Callback<void(CallbackStatus status,
+                                               media_perception::State state)>;
+  void GetState(const APIStateCallback& callback);
+  void SetState(const media_perception::State& state,
+                const APIStateCallback& callback);
+
+  using APIGetDiagnosticsCallback =
+      base::Callback<void(CallbackStatus status,
+                          media_perception::Diagnostics diagnostics)>;
+  void GetDiagnostics(const APIGetDiagnosticsCallback& callback);
+
+ private:
+  friend class BrowserContextKeyedAPIFactory<MediaPerceptionAPIManager>;
+
+  // BrowserContextKeyedAPI:
+  static const char* service_name() { return "MediaPerceptionAPIManager"; }
+
+  // Sets the state of the analytics process.
+  void SetStateInternal(const APIStateCallback& callback,
+                        const mri::State& state);
+
+  // Event handler for MediaPerception proto messages coming over D-Bus as
+  // signal.
+  void MediaPerceptionSignalHandler(
+      const mri::MediaPerception& media_perception);
+
+  // Callback for State D-Bus method calls to the media analytics process.
+  void StateCallback(const APIStateCallback& callback,
+                     bool succeeded,
+                     const mri::State& state);
+
+  // Callback for GetDiagnostics D-Bus method calls to the media analytics
+  // process.
+  void GetDiagnosticsCallback(const APIGetDiagnosticsCallback& callback,
+                              bool succeeded,
+                              const mri::Diagnostics& diagnostics);
+
+  // Callback for Upstart command to start media analytics process.
+  void UpstartCallback(const APIStateCallback& callback,
+                       const mri::State& state,
+                       bool succeeded);
+
+  content::BrowserContext* const browser_context_;
+
+  // Keeps track of whether the analytics process is running so that it can be
+  // started with an Upstart D-Bus method call if necessary.
+  AnalyticsProcessState analytics_process_state_;
+
+  base::WeakPtrFactory<MediaPerceptionAPIManager> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(MediaPerceptionAPIManager);
+};
+
+}  // namespace extensions
+
+#endif  // EXTENSIONS_BROWSER_API_MEDIA_PERCEPTION_PRIVATE_MEDIA_PERCEPTION_API_MANAGER_H_