Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 285823002: [webcrypto] Remove RSA-ES support (1 of 3) (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 7 months ago
Reviewers:
adamk
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

[webcrypto] Remove RSA-ES support (1 of 3) Removes RSA-ES from the LayoutTests. BUG=372920, 245025 R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174457

Patch Set 1 #

Patch Set 2 : Fix some usages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -968 lines) Patch
D LayoutTests/crypto/clone-rsaKey-private.html View 1 chunk +0 lines, -97 lines 0 comments Download
D LayoutTests/crypto/clone-rsaKey-private-expected.txt View 1 chunk +0 lines, -353 lines 0 comments Download
D LayoutTests/crypto/clone-rsaKey-public.html View 1 chunk +0 lines, -97 lines 0 comments Download
D LayoutTests/crypto/clone-rsaKey-public-expected.txt View 1 chunk +0 lines, -353 lines 0 comments Download
M LayoutTests/crypto/exportKey-unextractable.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/resources/subtle-crypto-concurrent.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/crypto/rsa-es-generateKey-parseAlgorithm-failures.html View 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/crypto/rsa-es-generateKey-parseAlgorithm-failures-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/crypto/sign-verify-badParameters.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/sign-verify-badParameters-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
adamk
This change lgtm, but why not land it at the same time as https://codereview.chromium.org/284973002/? Blink ...
6 years, 7 months ago (2014-05-20 08:13:32 UTC) #1
eroman
It is part of a 3-sided patch. (1) First I remove the tests for AES-ES ...
6 years, 7 months ago (2014-05-20 19:58:05 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 01:10:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/285823002/1
6 years, 7 months ago (2014-05-21 01:11:15 UTC) #4
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 01:35:43 UTC) #5
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 01:39:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/285823002/20001
6 years, 7 months ago (2014-05-21 01:39:49 UTC) #7
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 01:48:52 UTC) #8
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 01:59:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/285823002/60001
6 years, 7 months ago (2014-05-21 01:59:34 UTC) #10
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 15:04:05 UTC) #11
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 15:04:08 UTC) #12
eroman
6 years, 7 months ago (2014-05-21 15:24:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 manually as r174457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698