Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2858223004: Rename KernelElementAdapter and element_adapter.dart to IrToElementMap and ir_map.dart (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename KernelElementAdapter and element_adapter.dart to IrToElementMap and ir_map.dart R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ca01b7c1afa8314aad876daec495b2caf4200330

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+656 lines, -1969 lines) Patch
D pkg/compiler/lib/src/kernel/element_adapter.dart View 1 chunk +0 lines, -788 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 1 chunk +602 lines, -1125 lines 0 comments Download
A + pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 14 chunks +15 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/native_basic_data.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/no_such_method_resolver.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/types.dart View 1 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 4 chunks +10 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-05 11:22:17 UTC) #2
Siggi Cherem (dart-lang)
I like the general rename, but I'd prefer to use Kernel instead of Ir in ...
3 years, 7 months ago (2017-05-05 18:04:21 UTC) #3
Johnni Winther
https://codereview.chromium.org/2858223004/diff/1/pkg/compiler/lib/src/kernel/element_map.dart File pkg/compiler/lib/src/kernel/element_map.dart (right): https://codereview.chromium.org/2858223004/diff/1/pkg/compiler/lib/src/kernel/element_map.dart#newcode43 pkg/compiler/lib/src/kernel/element_map.dart:43: class KernelToElementMap extends IrToElementMapMixin { On 2017/05/05 18:04:21, Siggi ...
3 years, 7 months ago (2017-05-08 08:39:00 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-08 08:51:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ca01b7c1afa8314aad876daec495b2caf4200330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698