Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: content/browser/appcache/appcache_response.h

Issue 2858133002: Add uma stats to help evaluate the impact of changes to the quota allocation logic. (Closed)
Patch Set: macros Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/appcache/appcache_disk_cache.cc ('k') | content/browser/appcache/appcache_response.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_response.h
diff --git a/content/browser/appcache/appcache_response.h b/content/browser/appcache/appcache_response.h
index 47f33522475238740ab41df08b4eda977df1fd7a..86c7e1be8446aa29e1857d8b1727e58e4ed4eaa9 100644
--- a/content/browser/appcache/appcache_response.h
+++ b/content/browser/appcache/appcache_response.h
@@ -94,7 +94,8 @@ class CONTENT_EXPORT AppCacheDiskCacheInterface {
virtual ~Entry() {}
};
- AppCacheDiskCacheInterface();
+ // The uma_name pointer must remain valid for the life of the object.
+ AppCacheDiskCacheInterface(const char* uma_name);
virtual int CreateEntry(int64_t key,
Entry** entry,
@@ -105,11 +106,13 @@ class CONTENT_EXPORT AppCacheDiskCacheInterface {
virtual int DoomEntry(int64_t key,
const net::CompletionCallback& callback) = 0;
+ const char* uma_name() const { return uma_name_; }
base::WeakPtr<AppCacheDiskCacheInterface> GetWeakPtr();
protected:
virtual ~AppCacheDiskCacheInterface();
+ const char* uma_name_;
base::WeakPtrFactory<AppCacheDiskCacheInterface> weak_factory_;
};
« no previous file with comments | « content/browser/appcache/appcache_disk_cache.cc ('k') | content/browser/appcache/appcache_response.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698