tools/metrics/histograms/histograms.xml - Issue 2858133002: Add uma stats to help evaluate the impact of changes to the quota allocation logic.

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2858133002: Add uma stats to help evaluate the impact of changes to the quota allocation logic. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 3cb4e1df495072edb9f3a50c9caa48d1d4a48e68..55f153edd667621ea4bc52331d5789a2513d16a4 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -71859,6 +71859,20 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Storage.BytesRead" units="bytes">

Ilya Sherman 2017/05/19 00:17:14 nit: I think you never emit to this histogram with

michaeln 2017/05/19 01:22:05 Done.

+ <owner>michaeln@chromium.org</owner>

+ <summary>

+ The number of bytes read. Recorded on each read.

+ </summary>

+</histogram>

+<histogram name="Storage.BytesWritten" units="bytes">

+ <owner>michaeln@chromium.org</owner>

+ <summary>

+ The number of bytes written. Recorded on each write.

+ </summary>

+</histogram>

<histogram name="Storage.ImportantSites.CBDChosenReason"

enum="ImportantSitesReason">

<owner>dmurph@chromium.org</owner>

@@ -92528,6 +92542,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<affected-histogram name="Storage.Blob.SizeEvictedToDiskInKB"/>

</histogram_suffixes>

+<histogram_suffixes name="Storage.Bytes" separator=".">

+ <suffix name="DiskCache.AppCache"/>

+ <suffix name="DiskCache.CacheStorage"/>

+ <suffix name="DiskCache.ServiceWorker"/>

Ilya Sherman 2017/05/19 00:17:14 nit: Please add a (brief) label for each suffix.

michaeln 2017/05/19 01:22:05 i think it's self explanatory, no?

Ilya Sherman 2017/05/19 06:24:45 It is, but it's still nice to include a brief labe

+ <suffix name="LevelDBEnv" label="Undifferentiated leveldb use."/>

+ <suffix name="LevelDBEnv.IDB"/>

+ <suffix name="LevelDBEnv.ServiceWorker"/>

+ <affected-histogram name="Storage.BytesRead"/>

+ <affected-histogram name="Storage.BytesWritten"/>

+</histogram_suffixes>

<histogram_suffixes name="StunPingInternal" separator=".">

« storage/common/storage_histograms.cc ('K') | « third_party/leveldatabase/env_chromium.cc ('k') | no next file » | no next file with comments »