Have mash_browser_tests recreate BackgroundServiceManager per test

services/ui/service.cc

Index: services/ui/service.cc
diff --git a/services/ui/service.cc b/services/ui/service.cc
index f44fe0467da9605072fafb53c7615df3dc25d3f1..4b65f678bdeba90ff14f6c9e6c995ac6fa61af72 100644
--- a/services/ui/service.cc
+++ b/services/ui/service.cc
@@ -100,9 +100,9 @@ Service::~Service() {
 #endif
 }
 
-void Service::InitializeResources(service_manager::Connector* connector) {
+bool Service::InitializeResources(service_manager::Connector* connector) {
   if (ui::ResourceBundle::HasSharedInstance())
-    return;
+    return true;
 
   std::set<std::string> resource_paths;
   resource_paths.insert(kResourceFileStrings);
@@ -112,7 +112,10 @@ void Service::InitializeResources(service_manager::Connector* connector) {
   catalog::ResourceLoader loader;
   filesystem::mojom::DirectoryPtr directory;
   connector->BindInterface(catalog::mojom::kServiceName, &directory);
-  CHECK(loader.OpenFiles(std::move(directory), resource_paths));
+  if (!loader.OpenFiles(std::move(directory), resource_paths)) {
+    LOG(ERROR) << "Service failed to open resource files.\n";
+    return false;
+  }
 
   ui::RegisterPathProvider();
 
@@ -125,6 +128,7 @@ void Service::InitializeResources(service_manager::Connector* connector) {
                          ui::SCALE_FACTOR_100P);
   rb.AddDataPackFromFile(loader.TakeFile(kResourceFile200),
                          ui::SCALE_FACTOR_200P);
+  return true;
 }
 
 Service::UserState* Service::GetUserState(
@@ -156,7 +160,9 @@ void Service::OnStart() {
   if (test_config_)
     ui::test::EnableTestConfigForPlatformWindows();
 
-  InitializeResources(context()->connector());
+  // If resources are unavailable do not complete start-up.
+  if (!InitializeResources(context()->connector()))

[jonross, 2017/05/16 21:54:45]

We talked offline about shutting down in response to no resources. Currently the
services are started by a ServiceContext, which awaits connection errors before
shutting down. There isn't a direct shutdown path within them.

Do we want to adjust this? Have Service::OnStart also begin returning a bool,
and having the ServiceContext also close out in that case?

[sky, 2017/05/17 16:58:59]

I don't think we should change OnStart(), but could we instead make this code
stop the service itself? Basically call QuitNow() on the context.

[jonross, 2017/05/18 19:23:28]

Done.

+    return;
 
 #if defined(USE_OZONE)
   // The ozone platform can provide its own event source. So initialize the