Have mash_browser_tests recreate BackgroundServiceManager per test

services/ui/service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/ui/service.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 93 matching lines @@
     return;
 
   std::set<std::string> resource_paths;
   resource_paths.insert(kResourceFileStrings);
   resource_paths.insert(kResourceFile100);
   resource_paths.insert(kResourceFile200);
 
   catalog::ResourceLoader loader;
   filesystem::mojom::DirectoryPtr directory;
   connector->BindInterface(catalog::mojom::kServiceName, &directory);
-  CHECK(loader.OpenFiles(std::move(directory), resource_paths));
+  if (!loader.OpenFiles(std::move(directory), resource_paths)) {

[sky, 2017/05/12 17:16:47]

The reason this CHECKs is because to do otherwise leaves the client in a very
bad state, a state that they are likely to crash on soon. For example,
Resourcebundle is not registered if you early return so that any access to it is
going to CHECK. In other words, I think an early return here is just going to
push the crash around.

What client is being started after the filesystem shuts down?

[jonross, 2017/05/12 18:08:02]

There appears to be a race on short run tests which don't bring up visuals.

As the UI Service wouldn't be done initializing by the time the ServiceContext
for the filesystem has been destroyed.

So while UI service is completely useless without these resources, it would
subsequently be notified of teardown. And cleanly shutdown.

Would it be more appropriate to use this as an additional signal to start the
shutdown?

+    LOG(ERROR) << "Service failed to open resource files.\n";
+    return;
+  }
 
   ui::RegisterPathProvider();
 
   // Initialize resource bundle with 1x and 2x cursor bitmaps.
   ui::ResourceBundle::InitSharedInstanceWithPakFileRegion(
       loader.TakeFile(kResourceFileStrings),
       base::MemoryMappedFile::Region::kWholeFile);
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   rb.AddDataPackFromFile(loader.TakeFile(kResourceFile100),
                          ui::SCALE_FACTOR_100P);
@@ skipping 296 matching lines @@
     mojom::WindowServerTestRequest request) {
   if (!test_config_)
     return;
   mojo::MakeStrongBinding(
       base::MakeUnique<ws::WindowServerTestImpl>(window_server_.get()),
       std::move(request));
 }
 
 
 }  // namespace ui