Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: chrome/browser/component_updater/recovery_component_installer.cc

Issue 2858073002: Use constexpr TaskTraits constructor in chrome. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/recovery_component_installer.cc
diff --git a/chrome/browser/component_updater/recovery_component_installer.cc b/chrome/browser/component_updater/recovery_component_installer.cc
index 7b72e3de143aa249b2e6f8533c84efd55e15743e..1bd9bfbdfa1dc90da371f6ebab067df91eb19eca 100644
--- a/chrome/browser/component_updater/recovery_component_installer.cc
+++ b/chrome/browser/component_updater/recovery_component_installer.cc
@@ -226,21 +226,17 @@ void DoElevatedInstallRecoveryComponent(const base::FilePath& path) {
#endif
// This task joins a process, hence .WithBaseSyncPrimitives().
base::PostTaskWithTraits(
- FROM_HERE, base::TaskTraits()
- .WithShutdownBehavior(
- base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN)
- .WithPriority(base::TaskPriority::BACKGROUND)
- .WithBaseSyncPrimitives(),
+ FROM_HERE,
+ {base::WithBaseSyncPrimitives(), base::TaskPriority::BACKGROUND,
+ base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN},
base::Bind(&WaitForElevatedInstallToComplete, base::Passed(&process)));
}
void ElevatedInstallRecoveryComponent(const base::FilePath& installer_path) {
base::PostTaskWithTraits(
- FROM_HERE, base::TaskTraits()
- .WithShutdownBehavior(
- base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN)
- .WithPriority(base::TaskPriority::BACKGROUND)
- .MayBlock(),
+ FROM_HERE,
+ {base::MayBlock(), base::TaskPriority::BACKGROUND,
+ base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN},
base::Bind(&DoElevatedInstallRecoveryComponent, installer_path));
}
@@ -372,11 +368,9 @@ bool RecoveryComponentInstaller::RunInstallCommand(
// Let worker pool thread wait for us so we don't block Chrome shutdown.
// This task joins a process, hence .WithBaseSyncPrimitives().
base::PostTaskWithTraits(
- FROM_HERE, base::TaskTraits()
- .WithShutdownBehavior(
- base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN)
- .WithPriority(base::TaskPriority::BACKGROUND)
- .WithBaseSyncPrimitives(),
+ FROM_HERE,
+ {base::WithBaseSyncPrimitives(), base::TaskPriority::BACKGROUND,
+ base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN},
base::Bind(&WaitForInstallToComplete, base::Passed(&process),
installer_folder, prefs_));

Powered by Google App Engine
This is Rietveld 408576698