chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc - Issue 2858073002: Use constexpr TaskTraits constructor in chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc

Issue 2858073002: Use constexpr TaskTraits constructor in chrome. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_syncer.cc ('k') | chrome/browser/chromeos/login/login_utils_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc

diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc

index 617a3be156fa6d7cdf52b27f5989e9b14d63fa60..6376a3c59d9621173dd0a212cba5095009f80b1f 100644

--- a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc

+++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc

@@ -339,8 +339,8 @@ void EasyUnlockTpmKeyManager::CreateKeyInSystemSlot(

// This task interacts with the TPM, hence MayBlock().

base::PostTaskWithTraits(

- FROM_HERE, base::TaskTraits().MayBlock().WithShutdownBehavior(

- base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN),

+ FROM_HERE,

+ {base::MayBlock(), base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN},

base::Bind(&CreateTpmKeyPairOnWorkerThread, base::Passed(&system_slot),

public_key, base::ThreadTaskRunnerHandle::Get(),

base::Bind(&EasyUnlockTpmKeyManager::OnTpmKeyCreated,

@@ -356,8 +356,8 @@ void EasyUnlockTpmKeyManager::SignDataWithSystemSlot(

// This task interacts with the TPM, hence MayBlock().

base::PostTaskWithTraits(

- FROM_HERE, base::TaskTraits().MayBlock().WithShutdownBehavior(

- base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN),

+ FROM_HERE,

+ {base::MayBlock(), base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN},

base::Bind(&SignDataOnWorkerThread, base::Passed(&system_slot),

public_key, data, base::ThreadTaskRunnerHandle::Get(),

base::Bind(&EasyUnlockTpmKeyManager::OnDataSigned,