components/security_interstitials/core/browser/resources/interstitial_v2.js - Issue 2858043004: Support interstitials with no primary button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/browser/resources/interstitial_v2.js

Issue 2858043004: Support interstitials with no primary button (Closed)

Patch Set: Fix iOS CanGoBack implementation Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/security_interstitials/content/security_interstitial_controller_client.cc ('k') | components/security_interstitials/core/controller_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/browser/resources/interstitial_v2.js

diff --git a/components/security_interstitials/core/browser/resources/interstitial_v2.js b/components/security_interstitials/core/browser/resources/interstitial_v2.js

index 4fa48eac865d91d45a46eb37c794bca79e03efa5..88ad830ed442ce35f4ad9ba9febda5bced2ccc4b 100644

--- a/components/security_interstitials/core/browser/resources/interstitial_v2.js

+++ b/components/security_interstitials/core/browser/resources/interstitial_v2.js

@@ -102,8 +102,7 @@ function setupEvents() {

var ssl = interstitialType == 'SSL';

var captivePortal = interstitialType == 'CAPTIVE_PORTAL';

var badClock = ssl && loadTimeData.getBoolean('bad_clock');

- var hidePrimaryButton = badClock && loadTimeData.getBoolean(

- 'hide_primary_button');

+ var hidePrimaryButton = loadTimeData.getBoolean('hide_primary_button');

if (ssl) {

$('body').classList.add(badClock ? 'bad-clock' : 'ssl');