chrome/browser/ssl/captive_portal_blocking_page.cc - Issue 2858043004: Support interstitials with no primary button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.cc

Issue 2858043004: Support interstitials with no primary button (Closed)

Patch Set: Fix iOS build Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/captive_portal_blocking_page.cc

diff --git a/chrome/browser/ssl/captive_portal_blocking_page.cc b/chrome/browser/ssl/captive_portal_blocking_page.cc

index eff1f47086573ed5b2d9b63d00d5bc419c540b81..dab93558565781babb7a465166bb24f5cc8d47ef 100644

--- a/chrome/browser/ssl/captive_portal_blocking_page.cc

+++ b/chrome/browser/ssl/captive_portal_blocking_page.cc

@@ -147,6 +147,7 @@ void CaptivePortalBlockingPage::PopulateInterstitialStrings(

load_time_data->SetString("iconClass", "icon-offline");

load_time_data->SetString("type", "CAPTIVE_PORTAL");

load_time_data->SetBoolean("overridable", false);

+ load_time_data->SetBoolean("hide_primary_button", false);

// |IsWifiConnection| isn't accurate on some platforms, so always try to get

// the Wi-Fi SSID even if |IsWifiConnection| is false.