components/security_interstitials/content/security_interstitial_controller_client.h - Issue 2858043004: Support interstitials with no primary button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/content/security_interstitial_controller_client.h

Issue 2858043004: Support interstitials with no primary button (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/security_interstitials/content/security_interstitial_controller_client.cc » ('j') | components/security_interstitials/content/security_interstitial_controller_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/content/security_interstitial_controller_client.h

diff --git a/components/security_interstitials/content/security_interstitial_controller_client.h b/components/security_interstitials/content/security_interstitial_controller_client.h

index 1d70720718c6397d2082bce4b2a8baa71d5c409e..b77a1b7aaf4950673a4db11d7000c42e210d2713 100644

--- a/components/security_interstitials/content/security_interstitial_controller_client.h

+++ b/components/security_interstitials/content/security_interstitial_controller_client.h

@@ -48,8 +48,9 @@ class SecurityInterstitialControllerClient

const std::string& GetApplicationLocale() const override;

bool CanLaunchDateAndTimeSettings() override;

void LaunchDateAndTimeSettings() override;

+ bool CanGoBack() override;

felt 2017/05/05 00:31:14 nit: can you move this to be next to GoBack()?

edwardjung 2017/05/05 10:24:24 Done.

-protected:

+ protected:

// security_interstitials::ControllerClient overrides.

const std::string GetExtendedReportingPrefName() const override;

content::WebContents* web_contents_;