components/security_interstitials/content/security_interstitial_controller_client.cc - Issue 2858043004: Support interstitials with no primary button

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/security_interstitials/content/security_interstitial_controller_client.cc

Issue 2858043004: Support interstitials with no primary button (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/security_interstitials/content/security_interstitial_controller_client.h ('K') | « components/security_interstitials/content/security_interstitial_controller_client.h ('k') | components/security_interstitials/core/browser/resources/interstitial_v2.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/security_interstitials/content/security_interstitial_contro ller_client.h"	5 #include "components/security_interstitials/content/security_interstitial_contro ller_client.h"

6	6

7 #include <utility>	7 #include <utility>

8	8

9 #include "components/prefs/pref_service.h"	9 #include "components/prefs/pref_service.h"

10 #include "components/safe_browsing_db/safe_browsing_prefs.h"	10 #include "components/safe_browsing_db/safe_browsing_prefs.h"

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92	92

93 bool SecurityInterstitialControllerClient::CanLaunchDateAndTimeSettings() {	93 bool SecurityInterstitialControllerClient::CanLaunchDateAndTimeSettings() {

94 NOTREACHED();	94 NOTREACHED();

95 return false;	95 return false;

96 }	96 }

97	97

98 void SecurityInterstitialControllerClient::LaunchDateAndTimeSettings() {	98 void SecurityInterstitialControllerClient::LaunchDateAndTimeSettings() {

99 NOTREACHED();	99 NOTREACHED();

100 }	100 }

101	101

	102 // For testing, should be set in the WV controller.
	felt 2017/05/05 00:31:14 I'm confused by this comment I'm confused by this comment edwardjung 2017/05/05 10:24:24 Wasn't sure whether this was going to be hard code Show quoted text On 2017/05/05 00:31:14, felt wrote: > I'm confused by this comment Wasn't sure whether this was going to be hard coded for the desktop. I've changed this.
	103 bool SecurityInterstitialControllerClient::CanGoBack() {

	104 return true;

	105 }

	106

102 } // namespace security_interstitials	107 } // namespace security_interstitials

OLD	NEW