Chromium Code Reviews
Help | Chromium Project | Sign in
(17)

Issue 2858014: Linux: make cups (common unix printing system) dependency optional. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by Paweł Hajdan Jr.
Modified:
4 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: make cups (common unix printing system) dependency optional. This is upstreaming a Gentoo Linux patch. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50432

Patch Set 1 #

Total comments: 1

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/chrome.gyp View 1 2 chunks +10 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 9 (0 generated)
Paweł Hajdan Jr.
4 years, 11 months ago (2010-06-18 08:07:11 UTC) #1
Mark Mentovai - out til August
I don’t know what this has to do with target_arch, but that was already there. ...
4 years, 11 months ago (2010-06-18 14:36:25 UTC) #2
Paweł Hajdan Jr.
+maruel (it's printing-related, Linux) sanjeevr/scottbyer: ping I'd like to get an "LGTM" from at least ...
4 years, 11 months ago (2010-06-21 06:29:10 UTC) #3
M-A Ruel
Is it only needed for chrome for chromeos?
4 years, 11 months ago (2010-06-21 13:54:06 UTC) #4
sanjeevr
Sorry for the delay, this slipped under my radar. Can I get a little more ...
4 years, 11 months ago (2010-06-21 17:40:27 UTC) #5
Paweł Hajdan Jr.
On Mon, Jun 21, 2010 at 19:40, <sanjeevr@chromium.org> wrote: > Sorry for the delay, this ...
4 years, 11 months ago (2010-06-21 17:49:10 UTC) #6
sanjeevr
So the idea is to use CUPS as the print system for the Linux cloud ...
4 years, 11 months ago (2010-06-21 18:07:59 UTC) #7
Paweł Hajdan Jr.
Patch updated, please take another look.
4 years, 11 months ago (2010-06-21 19:48:51 UTC) #8
sanjeevr
4 years, 11 months ago (2010-06-21 23:42:16 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be