PS - Showing permission prompt for activeTab

chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

Index: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
index 660055c2066d2d3e676826712d55846182c3ef94..dd2d1b74c319b003b74fef8cca81553747541a61 100644
--- a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
@@ -32,6 +32,7 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
+#include "chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos.h"
 #include "chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.h"
 #include "chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.h"
 #include "chrome/browser/chromeos/login/demo_mode/demo_app_launcher.h"
@@ -850,6 +851,12 @@ void ChromeUserManagerImpl::PublicAccountUserLoggedIn(
   // PermissionsUpdaterDelegateChromeOS for more info.
   extensions::ExtensionTabUtil::SetPlatformDelegate(
       new extensions::ExtensionTabUtilDelegateChromeOS);
+
+  // In Public Sessions set the PS delegate on ActiveTabPermissionGranter (used
+  // to ask the user for activeTab permission for security reasons). See comment
+  // above about PermissionsUpdaterDelegateChromeOS for more info.
+  extensions::ActiveTabPermissionGranter::SetPlatformDelegate(
+      new extensions::ActiveTabPermissionGranterDelegateChromeOS);

[Andrew T Wilson (Slow), 2017/05/09 13:29:29]

This comment is fine as-is, but it's basically a copy-paste of the previous
comment. You could probably make a single comment that describes both pieces of
delegate setting and make this code slightly easier to read.

[Ivan Šandrk, 2017/05/10 10:01:28]

Put them all in a separate function, does it look better now?

 }
 
 void ChromeUserManagerImpl::KioskAppLoggedIn(user_manager::User* user) {